Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[various] Run swift-format on example app Swift files #5931

Merged
merged 2 commits into from
Jan 19, 2024
Merged

[various] Run swift-format on example app Swift files #5931

merged 2 commits into from
Jan 19, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 19, 2024

Run swift-format linter/formatter on Swift files in example apps. This doesn't touch any Swift files in non-example code.

Part of turning on swift-format CI formatting #5928

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman marked this pull request as ready for review January 19, 2024 01:45
stuartmorgan
stuartmorgan approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/animations/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## NEXT

* Fixes Swift format issues in example app.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit: you could revert all of the CHANGELOG changes, as this would fall under the "only affect[s] development of the package" exemption; formatting of the boilerplate runner code isn't going to be of interest to clients.

@jmagman jmagman added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes autosubmit Merge PR when tree becomes green via auto submit App labels Jan 19, 2024
@auto-submit auto-submit bot merged commit 4dd91ce into flutter:main Jan 19, 2024
80 checks passed
@jmagman jmagman deleted the swift-format-examples branch January 19, 2024 04:55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 19, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 19, 2024
@engine-flutter-autoroll
4dd91ce [various] Run swift-format on example app Swift files (flutte…
e70d995 
…r/packages#5931)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 19, 2024
@engine-flutter-autoroll
Roll Packages from 83c2c4d to 129e08c (13 revisions) (#141865)
0487931 
flutter/packages@83c2c4d...129e08c

2024-01-19 [email protected] [pigeon] Run swift-format on ungenerated example app Swift files (flutter/packages#5934)
2024-01-19 [email protected] [path_provider_foundation] Run swift-format on Swift files (flutter/packages#5935)
2024-01-19 [email protected] [shared_preferences_foundation] Run swift-format on Swift files (flutter/packages#5933)
2024-01-19 [email protected] [various] Run swift-format on example app Swift files (flutter/packages#5931)
2024-01-19 [email protected] [camera_avfoundation] Remove development team from Xcode example app (flutter/packages#5930)
2024-01-18 [email protected] [webview_flutter_wkwebview] Add javascript panel interface for wkwebview (flutter/packages#5795)
2024-01-18 [email protected] [two_dimensional_scrollables] Fix must_call_super (flutter/packages#5921)
2024-01-18 [email protected] [pointer_interceptor] fix width and height unset warning on web platform (flutter/packages#5864)
2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/packages#5922)
2024-01-18 [email protected] [google_maps_flutter] Clean up iOS example project (flutter/packages#5925)
2024-01-18 [email protected] [ci] Add flags to formatter command to decide which formatters to run (flutter/packages#5905)
2024-01-18 [email protected] Update tests to Xcode 15 and iOS 17 simulator (flutter/packages#5914)
2024-01-18 [email protected] Roll Flutter from def6af0 to f77f824 (25 revisions) (flutter/packages#5924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@jmagman @arc-yong
[various] Run swift-format on example app Swift files (flutter#5931)
4d014a0 
Run `swift-format` linter/formatter on Swift files in example apps.  This doesn't touch any Swift files in non-example code.

Part of turning on swift-format CI formatting flutter#5928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@Piinks Piinks Awaiting requested review from Piinks Piinks is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal is a code owner

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@gspencergoog gspencergoog Awaiting requested review from gspencergoog gspencergoog is a code owner

@chunhtai chunhtai Awaiting requested review from chunhtai chunhtai is a code owner

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: animations p: dynamic_layouts The dynamic_layouts package p: file_selector p: flutter_adaptive_scaffold p: flutter_image p: flutter_markdown p: go_router p: palette_generator p: path_provider p: pointer_interceptor p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmagman @stuartmorgan @hellohuanlin