[pigeon] Separates message call code generation into separate methods in the DartGenerator
#5859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bparrishMines
changed the title
DartGenerator
tarrinneal
reviewed
Jan 10, 2024
bparrishMines
force-pushed
the
pigeon_wrapper_dart_calls
branch
from
6af7aeb to
830de0a
Compare
tarrinneal
approved these changes
Jan 17, 2024
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2024
… methods in the `DartGenerator` (flutter/packages#5859)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2024
flutter/packages@1a2b780...83c2c4d 2024-01-18 [email protected] [google_maps_flutter] Restore the arm64 workaround (flutter/packages#5915) 2024-01-17 [email protected] [pigeon] Separates message call code generation into separate methods in the KotlinGenerator (flutter/packages#5891) 2024-01-17 [email protected] [webview_flutter_wkebview] Verify JavaScriptChannels have a unique name (flutter/packages#5904) 2024-01-17 [email protected] [pigeon] Separates message call code generation into separate methods in the `DartGenerator` (flutter/packages#5859) 2024-01-17 [email protected] Roll Flutter from 8e94423 to def6af0 (23 revisions) (flutter/packages#5911) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
… in the `DartGenerator` (flutter#5859) Separates message call code generation into separate methods in the `DartGenerator` for flutter/flutter#134777. The `ProxyApi` generator uses similar code to the `HostApi` and `FlutterApi`, so this makes the code reusable. Separated from flutter#5544 From suggestion: flutter#5544 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates message call code generation into separate methods in the
DartGeneratorfor flutter/flutter#134777. TheProxyApigenerator uses similar code to theHostApiandFlutterApi, so this makes the code reusable.Separated from #5544
From suggestion: #5544 (comment)
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.