[ci] Finalize migration to x64 specific Windows platform #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
This begins to migrate the Windows CI tests to use a new x64 specific Windows platform. For now these duplicate the existing tests in `bringup` mode. A subsequent pull request (#5141) will complete the migration by removing the old Windows tests and removing the `bringup` from the new x64 specific tests. Here are the resulting changes from both steps of the migration: main...loic-sharma:flutter-packages:windows_x64_ci_finalize In the future, a new platform will be added for Windows Arm64 tests. Prepares for flutter/flutter#129813 Subsequent pull requests: * #5141 * #5142
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
This begins to migrate the Windows CI tests to use a new x64 specific Windows platform. For now these duplicate the existing tests in `bringup` mode. A subsequent pull request (flutter#5141) will complete the migration by removing the old Windows tests and removing the `bringup` from the new x64 specific tests. Here are the resulting changes from both steps of the migration: flutter/packages@main...loic-sharma:flutter-packages:windows_x64_ci_finalize In the future, a new platform will be added for Windows Arm64 tests. Prepares for flutter/flutter#129813 Subsequent pull requests: * flutter#5141 * flutter#5142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainonce the previous pull request has landed.#5133 began to migrate the Windows CI tests to use a new x64 specific Windows platform. This completes the migration by removing the old Windows tests and removing
bringupfrom the new x64 specific tests.Here are the resulting changes from both steps of the migration: main...loic-sharma:flutter-packages:windows_x64_ci_finalize
Prepares for flutter/flutter#129813
Previous stacked pull request: #5133
Next stacked pull request: #5142
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.