-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios_platform_images] migrate objC to swift #4847
Merged
auto-submit
merged 39 commits into
flutter:main
from
Mairramer:ios_platform_images_swift_migration
Oct 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
ad9ed35
[ios_platform_images] migrate objC to swift
Mairramer e5545bc
pump version
Mairramer cf21182
added some tests
Mairramer 008d5d3
update tests
Mairramer e422e78
Merge branch 'main' into ios_platform_images_swift_migration
Mairramer b0122cf
fix format
Mairramer 54b9b92
Merge branch 'main' into ios_platform_images_swift_migration
Mairramer 6c29139
Merge branch 'main' into ios_platform_images_swift_migration
Mairramer f3ce031
improve code
Mairramer 100202a
rollback comment
Mairramer 97dc083
pump version
Mairramer 1a28d20
Merge branch 'main' into ios_platform_images_swift_migration
Mairramer 8da12bd
rollback implementation
Mairramer 50ce448
rollback original logic
Mairramer 59d7b6d
fix logic
Mairramer 17a369e
rollback logic
Mairramer cfbf55f
Merge branch 'main' into ios_platform_images_swift_migration
Mairramer 101c190
fix test
Mairramer 1d2969b
fix test
Mairramer 372ce11
fix scaled image and migrate tests
Mairramer 523a277
Merge remote-tracking branch 'origin/main' into ios_platform_images_s…
Mairramer aef7985
migrate pigeon to swift
Mairramer 78cbc82
format code
Mairramer 45d185d
fix build script
Mairramer a9a4879
improves
Mairramer 364be83
update readme
Mairramer aae7a29
rollback objC test
Mairramer cbbc208
fix test import
Mairramer ac54592
improves
Mairramer 3e66718
improve test
Mairramer 71f2589
fix test
Mairramer e2d9a9a
Merge branch 'main' into ios_platform_images_swift_migration
Mairramer 3324ccd
rollback
Mairramer e370d61
update readme
Mairramer b25d574
Revert whitespace change in podfile
stuartmorgan 5d03976
TODO style fix
stuartmorgan eaf7c90
Re-add DEFINES_MODULE
stuartmorgan 139e125
Merge branch 'main' into ios_platform_images_swift_migration
stuartmorgan 6ea1fc0
Merge branch 'main' into ios_platform_images_swift_migration
Mairramer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix test
- Loading branch information
commit 1d2969b629c9c8e0c40a13ff7ec0fd7da8f0ee70
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of the intermediate
imageResult
variable, rather than inlining the result?