Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Introduces API 34 emulators for tests #4804

Closed
wants to merge 58 commits into from

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Aug 28, 2023

Introduces API 34 emulators for tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

camsim99 added 30 commits May 1, 2023 16:46
@ricardoamador
Copy link
Contributor

How are we validating that flutter changes are compatible with newer emulator APIs?

@camsim99
Copy link
Contributor Author

How are we validating that flutter changes are compatible with newer emulator APIs?

Just by changing the emulator versions we use for testing in CI like this and seeing if there are any failures. There are failures on this PR that are blocking that but I'm working on #5105 to update the tests that I can to run on new emulators.

auto-submit bot pushed a commit that referenced this pull request Oct 24, 2023
Introduces API 34 emulators for subset of tests not causing test failures in #4804. Also changes linux_android version to 34v1.

Continuation of #4820.
@camsim99
Copy link
Contributor Author

Closing as I will be landing partial updates.

@camsim99 camsim99 closed this Oct 24, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
Introduces API 34 emulators for subset of tests not causing test failures in flutter#4804. Also changes linux_android version to 34v1.

Continuation of flutter#4820.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants