[flutter_markdown] Change the way tests get screen size #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of flutter/flutter#125003 the current method these tests use to get the screen width throws an exception, since it assumes that the first widget in the tree has certain properties. To make the test more robust, this get the width of the outmost Column, which is part of the test setup, rather than whatever the first widget is. Unblocks the flutter->packgaes roller.
domesticmouse
approved these changes
Jul 19, 2023
tarrinneal
approved these changes
Jul 19, 2023
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 19, 2023
flutter/packages@3e8b813...209db21 2023-07-19 [email protected] [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473) 2023-07-19 [email protected] Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518) 2023-07-19 [email protected] [ci] Enable new sharding (flutter/packages#4515) 2023-07-19 [email protected] [flutter_markdown] Change the way tests get screen size (flutter/packages#4514) 2023-07-18 [email protected] [ci] Roll Flutter to f842ed9 (flutter/packages#4513) 2023-07-18 [email protected] [image_picker] Update Android example (flutter/packages#4504) 2023-07-18 [email protected] [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511) 2023-07-18 [email protected] [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@3e8b813...209db21 2023-07-19 [email protected] [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473) 2023-07-19 [email protected] Manual roll Flutter from f842ed9 to 6f09064 (11 revisions) (flutter/packages#4518) 2023-07-19 [email protected] [ci] Enable new sharding (flutter/packages#4515) 2023-07-19 [email protected] [flutter_markdown] Change the way tests get screen size (flutter/packages#4514) 2023-07-18 [email protected] [ci] Roll Flutter to f842ed9 (flutter/packages#4513) 2023-07-18 [email protected] [image_picker] Update Android example (flutter/packages#4504) 2023-07-18 [email protected] [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511) 2023-07-18 [email protected] [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of flutter/flutter#125003 the current method these tests use to get the screen width throws an exception, since it assumes that the first widget in the tree has certain properties. To make the test more robust, this get the width of the outmost Column, which is part of the test setup, rather than whatever the first widget is.
Unblocks the flutter->packgaes roller.