Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quick_actions] Fix iOS home screen quick actions documentation hyperlink #4059

Merged
merged 5 commits into from
May 24, 2023
Merged

[quick_actions] Fix iOS home screen quick actions documentation hyperlink #4059

merged 5 commits into from
May 24, 2023

Conversation

phcs971
Copy link
Contributor

@phcs971 phcs971 commented May 22, 2023 •
edited
Loading

Replaces the old documentation link for the iOS Quick Actions (https://developer.apple.com/design/human-interface-guidelines/ios/system-capabilities/home-screen-actions/) to the new one (https://developer.apple.com/design/human-interface-guidelines/home-screen-quick-actions)

The old one is going to a not found page:
image

Once this is just a simple documentation change I believe this is exempt from the version change requirement and request for the "override: no versioning needed" to be added.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@phcs971 phcs971 requested a review from bparrishMines as a code owner May 22, 2023 13:53
@google-cla
Copy link

google-cla bot commented May 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bparrishMines
bparrishMines previously requested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the change, but still needs the version bump.

This does require a patch version bump since it updates the README that is shown on pub.dev.

cc @stuartmorgan @tarrinneal for secondary review

tarrinneal
tarrinneal approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once @bparrishMines change requests are fulfilled

@phcs971 phcs971 requested a review from bparrishMines May 23, 2023 17:58
@phcs971
Copy link
Contributor Author

phcs971 commented May 23, 2023 •
edited
Loading

LGTM on the change, but still needs the version bump.

This does require a patch version bump since it updates the README that is shown on pub.dev.

cc @stuartmorgan @tarrinneal for secondary review

updated version to 1.0.4 1.0.5

stuartmorgan
stuartmorgan approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I wish Apple weren't so fond of constantly reorganizing developer docs without adding redirects from old locations :(

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 24, 2023

auto label is removed for flutter/packages, pr: 4059, due to This PR has not met approval requirements for merging. Changes were requested by {bparrishMines}, please make the needed changes and resubmit this PR.
You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@stuartmorgan stuartmorgan dismissed bparrishMines’s stale review May 24, 2023 15:17

Addressed in follow-up

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2023
@auto-submit auto-submit bot merged commit f19282a into flutter:main May 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 25, 2023
@engine-flutter-autoroll
f19282a [quick_actions] Fix iOS home screen quick actions documentati…
e61dc5d 
…on hyperlink (flutter/packages#4059)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 25, 2023
@engine-flutter-autoroll
Roll Packages from fba97fa to 995bfc5 (3 revisions) (#127590)
3e610f7 
flutter/packages@fba97fa...995bfc5

2023-05-24 [email protected] Roll Flutter from f86c529 to 216605b (18 revisions) (flutter/packages#4071)
2023-05-24 [email protected] [various] Fixes `unawaited_futures` violations (flutter/packages#4067)
2023-05-24 [email protected] [quick_actions] Fix iOS home screen quick actions documentation hyperlink (flutter/packages#4059)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: quick_actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phcs971 @stuartmorgan @bparrishMines @tarrinneal