mistakes were made

flutter · May 23, 2023 · 34a83bc · 34a83bc
1 parent 1d6732b
commit 34a83bc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/packages/image_picker/image_picker/example/lib/main.dart b/packages/image_picker/image_picker/example/lib/main.dart
@@ -134,7 +134,7 @@ class _MyHomePageState extends State<MyHomePage> {
         await _displayPickImageDialog(context,
             (double? maxWidth, double? maxHeight, int? quality) async {
           try {
-            final List<XFile> pickedFileList = [];
+            final List<XFile> pickedFileList = <XFile>[];
             final XFile? media = await _picker.pickMedia(
               maxWidth: maxWidth,
               maxHeight: maxHeight,

diff --git a/...icker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerPlugin.java b/...icker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerPlugin.java
@@ -332,6 +332,7 @@ public void pickMedia(
       @NonNull Messages.ImageSelectionOptions imageOptions,
       @NonNull Messages.VideoSelectionOptions videoOptions,
       @NonNull Boolean usePhotoPicker,
+      @NonNull Boolean allowMultiple,
       @NonNull Result<List<String>> result) {
     ImagePickerDelegate delegate = getImagePickerDelegate();
     if (delegate == null) {
@@ -340,7 +341,7 @@ public void pickMedia(
               "no_activity", "image_picker plugin requires a foreground activity.", null));
       return;
     }
-    delegate.chooseMediaFromGallery(imageOptions, videoOptions, usePhotoPicker, result);
+    delegate.chooseMediaFromGallery(imageOptions, videoOptions, usePhotoPicker, allowMultiple, result);
   }
 
   @Override

diff --git a/packages/image_picker/image_picker_ios/example/ios/RunnerTests/ImagePickerPluginTests.m b/packages/image_picker/image_picker_ios/example/ios/RunnerTests/ImagePickerPluginTests.m
@@ -199,6 +199,7 @@ - (void)testPickMediaShouldUseUIImagePickerControllerOnPreiOS14 {
       pickMediaWithMaxSize:[FLTMaxSize makeWithWidth:@(100) height:@(200)]
                    quality:@(50)
               fullMetadata:@YES
+             allowMultiple:@YES
                 completion:^(NSArray<NSString *> *_Nullable result, FlutterError *_Nullable error){
                 }];
   OCMVerify(times(1),
@@ -251,6 +252,8 @@ - (void)testPickMediaWithoutFullMetadata {
       pickMediaWithMaxSize:[[FLTMaxSize alloc] init]
                    quality:nil
               fullMetadata:@NO
+             allowMultiple:@YES
+
                 completion:^(NSArray<NSString *> *_Nullable result, FlutterError *_Nullable error){
                 }];