Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tokens to v6.1 #153722

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Update tokens to v6.1 #153722

merged 3 commits into from
Sep 4, 2024

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Aug 19, 2024 •
edited
Loading

This PR is to update the token version to v6.1.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Aug 19, 2024
@QuncCccccc QuncCccccc marked this pull request as ready for review August 19, 2024 23:30
@QuncCccccc QuncCccccc requested a review from TahaTesser August 19, 2024 23:30
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #153722 at sha 5c35968

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Aug 19, 2024
TahaTesser
TahaTesser approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser
Copy link
Member

@QuncCccccc When this lands, i will update my Slider PR and remove the TODO #152237

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Aug 28, 2024 •
edited
Loading

@QuncCccccc When this lands, i will update my Slider PR and remove the TODO #152237

Thanks for letting me know! cl/665469788 is under review:)

@QuncCccccc QuncCccccc force-pushed the update_tokens_to_v6.1 branch from 5c35968 to cff6be2 Compare September 3, 2024 19:40
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2024
@auto-submit auto-submit bot merged commit 182c266 into flutter:master Sep 4, 2024
136 checks passed
@QuncCccccc QuncCccccc mentioned this pull request Sep 4, 2024
Merged
9 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
8bf50f1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
222c372
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
9d6b23e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
4feffc5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
7d11f00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
1944b5c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
56879a2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
e0881eb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
98eff6c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
164be95
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
0bc995c
@Piinks Piinks mentioned this pull request Sep 6, 2024
Closed
@QuncCccccc QuncCccccc mentioned this pull request Dec 9, 2024
Merged
4 tasks
QuncCccccc added a commit to flutter/website that referenced this pull request Dec 11, 2024
@QuncCccccc
Migration guide for M3 token update (#11480)
4e5c7d2 
This PR is to add a breaking change page for the Material 3 token change
in the material library(flutter/flutter#153722,
flutter/flutter#153385).

## Presubmit checklist

- [x] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
463fa0e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
182c26696 Update tokens to v6.1 (flutter/flutter#153722)
62dea57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Slider] Inactive/unselected stop indicator color is incorrect in the gen_defaults tokens.
2 participants
@QuncCccccc @TahaTesser