Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not silently fail pub get even if output-mode is "none" #153596

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Do not silently fail pub get even if output-mode is "none" #153596

merged 5 commits into from
Aug 22, 2024

Conversation

matanlurey
Copy link
Contributor

I am making an assumption OutputMode.none should really mean OutputMode.failuresOnly, that is, if we ever get a non-zero exit code, we still want to know why. If I've somehow misunderstood that, LMK and I'm happy to revert this PR or make adjustments.

This fixes the bug where if you were to do:

git clone https://github.com/myuser/fork-of-flutter
cd fork-of-flutter
./bin/flutter update-packages

You now get:

  1. An actual error message, versus no output at all.
  2. A warning that a common reason is not tracking a remote, with instructions to fix it.

Closes #148569.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 16, 2024
@matanlurey
Copy link
Contributor Author

One failure is essentially a lint - I can fix that.

The other is a test that expected no failure (pub get 66) but does produce a non-zero exit code.

I suspect updating the test is the right call, but I'm also not 100% sure.

andrewkolos
andrewkolos approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewkolos
Copy link
Contributor

I spoke a bit soon! Looks like this is failing test/general.shard/dart/pub_get_test.dart: pub get 66 shows message from pub

@matanlurey matanlurey requested a review from andrewkolos August 21, 2024 16:01
@andrewkolos
Copy link
Contributor

This is failing customer_testing due to seemingly unrelated compilation errors 🤷. I wonder what's going on and whether a rebase/merge would fix this PR.

@matanlurey matanlurey merged commit a9e94d9 into flutter:master Aug 22, 2024
129 checks passed
@matanlurey matanlurey deleted the flutter-update-packages-silent-failure branch August 22, 2024 16:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
815e608 
flutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
53f9a8d 
flutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
1061185 
flutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
8a0a476 
flutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
8910a94 
flutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
899d9e0 
flutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
e5302b2 
flutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
9001f0e 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
becb966 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
4cc9f56 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
2720cf3 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
e8d4799 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
cc64ad4 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
8b93922 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
ee37449 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
d073924 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
3106f93 
flutter/flutter#153596)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@matanlurey @Buchimi
Do not silently fail pub get even if output-mode is "none" (flutter…
c77548a 
…#153596)

I am making an assumption `OutputMode.none` should _really_ mean
`OutputMode.failuresOnly`, that is, if we ever get a non-zero exit code,
we still want to know why. If I've somehow misunderstood that, LMK and
I'm happy to revert this PR or make adjustments.

This fixes the bug where if you were to do:

```sh
git clone https://github.com/myuser/fork-of-flutter
cd fork-of-flutter
./bin/flutter update-packages
```

You now get:

1. An actual error message, versus no output at all.
2. A warning that a common reason is not tracking a remote, with
instructions to fix it.

Closes flutter#148569.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
d22b856 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
bb8f3ff 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
446bfa3 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
c965390 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
7118ef7 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
d1fa4a5 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
c12b17e 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
ec07d50 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
547d54b 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
40caae9 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
f4e62d5 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
dfe6403 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
7650cfe 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
378aac5 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
d71ef90 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
21fd4af 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
582cc2c 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
2557da3 
flutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
a9e94d904 Do not silently fail pub get even if output-mode is "none" (
b0a1749 
flutter/flutter#153596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmccutchan johnmccutchan Awaiting requested review from johnmccutchan

@andrewkolos andrewkolos Awaiting requested review from andrewkolos

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flutter update-packages can fail silently
2 participants
@matanlurey @andrewkolos