Retry connecting to device in CI after lost connection #133769

vashworth · 2023-08-31T15:49:01Z

Sometimes ios-deploy loses connection to the device after installing, starting debugserver, and launching. This is shown with an error message like:

Process 579 exited with status = -1 (0xffffffff) lost connection

This happens frequently in our CI system: #120808

Usually in CI, on retry it'll work and pass - so this is an attempt to retry without failing the test first. It's not guaranteed to fix since we're unable to recreate this error locally.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

vashworth · 2023-08-31T17:55:43Z

Google testing seems to be failing on something unrelated. I tried clicking "Re-run" but hasn't done anything yet. I'll give it a little time and if not, I'll update the branch to trigger it to rerun.

christopherfujino · 2023-08-31T19:25:49Z

packages/flutter_tools/lib/src/ios/devices.dart

-          portForwarder: isWirelesslyConnected ? null : portForwarder,
-          hostPort: debuggingOptions.hostVmServicePort,
-          devicePort: debuggingOptions.deviceVmServicePort,
+        vmServiceDiscovery = _setupDebuggerAndVmServiceDiscovery(


from a cursory look, this diff doesn't change anything, just factors out the left side logic to a helper method, is that right?

Pretty much, only difference is I added a skipInstall option

christopherfujino

LGTM

christopherfujino · 2023-08-31T21:22:06Z

BTW, your google testing failure looks like a bug with FRoB. I chatted with the release team who is on it, I think they are going to put out a PSA soon.

vashworth · 2023-08-31T21:23:29Z

BTW, your google testing failure looks like a bug with FRoB. I chatted with the release team who is on it, I think they are going to put out a PSA soon.

Thanks for the heads up!

…er/flutter#133769)

potential workaround fix

a593b9a

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 31, 2023

vashworth added 2 commits August 31, 2023 10:58

add comment and test

916cad4

fix typo

2b3a898

vashworth marked this pull request as ready for review August 31, 2023 17:53

vashworth requested a review from christopherfujino August 31, 2023 17:53

christopherfujino reviewed Aug 31, 2023

View reviewed changes

Merge branch 'master' into ios_deploy_lost_connection_workaround

2f17265

christopherfujino approved these changes Aug 31, 2023

View reviewed changes

Merge branch 'master' into ios_deploy_lost_connection_workaround

80ff717

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023

auto-submit bot merged commit 6c56421 into flutter:master Sep 5, 2023

vashworth mentioned this pull request Sep 5, 2023

Mac_ios hot_mode_dev_cycle_ios__benchmark is 2.00% flaky, Process exited with status = -1 (0xffffffff) lost connection #120808

Closed

engine-flutter-autoroll mentioned this pull request Sep 6, 2023

Roll Flutter from c175cf87a6a3 to 03fcfbef211c (88 revisions) flutter/packages#4854

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

37c2a1a

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 6, 2023

Roll Flutter from c175cf87a6a3 to 03b60ac75b8e (89 revisions) flutter/packages#4855

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

7d40014

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 6, 2023

Roll Flutter from c175cf87a6a3 to 99f5cf07df37 (90 revisions) flutter/packages#4856

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

998356e

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 6, 2023

Roll Flutter from c175cf87a6a3 to 61a388a44849 (91 revisions) flutter/packages#4857

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

5e3f3cc

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 6, 2023

Roll Flutter from c175cf87a6a3 to 195dca02c0e3 (92 revisions) flutter/packages#4858

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

0882ec8

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 6, 2023

Roll Flutter from c175cf87a6a3 to ee0a15d4f5ba (93 revisions) flutter/packages#4859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

2c7e686

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 6, 2023

Roll Flutter from c175cf87a6a3 to b0e5a5ca67b9 (94 revisions) flutter/packages#4860

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

c76bde6

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 6, 2023

Roll Flutter from c175cf87a6a3 to cd9a257d741f (95 revisions) flutter/packages#4861

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

ef8d561

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023

Roll Flutter from c175cf87a6a3 to bbf5d11aadb4 (111 revisions) flutter/packages#4864

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

62f4831

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023

Roll Flutter from c175cf87a6a3 to 6ddb3b04b4fe (112 revisions) flutter/packages#4865

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

8e37c2c

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023

Roll Flutter from c175cf87a6a3 to 2867b31f5ed4 (113 revisions) flutter/packages#4867

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

1d22bb1

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023

Roll Flutter from c175cf87a6a3 to aca91df6b784 (115 revisions) flutter/packages#4868

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

c8def9c

…er/flutter#133769)

engine-flutter-autoroll mentioned this pull request Sep 7, 2023

Roll Flutter from c175cf87a6a3 to ea351694fe5b (118 revisions) flutter/packages#4869

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

139f909

…er/flutter#133769)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

3192f32

…er/flutter#133769)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

6c56421 Retry connecting to device in CI after lost connection (flutt…

1249e4d

…er/flutter#133769)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retry connecting to device in CI after lost connection #133769

Retry connecting to device in CI after lost connection #133769

vashworth commented Aug 31, 2023 •

edited

Loading

vashworth commented Aug 31, 2023

christopherfujino Aug 31, 2023

vashworth Aug 31, 2023

christopherfujino left a comment

christopherfujino commented Aug 31, 2023

vashworth commented Aug 31, 2023

Retry connecting to device in CI after lost connection #133769

Retry connecting to device in CI after lost connection #133769

Conversation

vashworth commented Aug 31, 2023 • edited Loading

Pre-launch Checklist

vashworth commented Aug 31, 2023

christopherfujino Aug 31, 2023

Choose a reason for hiding this comment

vashworth Aug 31, 2023

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

christopherfujino commented Aug 31, 2023

vashworth commented Aug 31, 2023

vashworth commented Aug 31, 2023 •

edited

Loading