Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] handle exceptions raised while searching for configured android studio #133602

Merged
merged 2 commits into from
Sep 6, 2023
Merged

[CP] handle exceptions raised while searching for configured android studio #133602

merged 2 commits into from
Sep 6, 2023

Conversation

andrewkolos
Copy link
Contributor

cherry-pick for #133180

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 29, 2023
@andrewkolos andrewkolos mentioned this pull request Aug 29, 2023
Closed
@christopherfujino
Copy link
Member

Mac tool_integration_tests_2_4 looks like a network flake, retrying. cirrus tests are from an outdated access token, I'd leave it for now unless the release team wants to run those tests (they're redundant with LUCI tests)

@andrewkolos andrewkolos marked this pull request as ready for review August 30, 2023 19:52
christopherfujino
christopherfujino approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Sep 6, 2023
Merged
Merged
@XilaiZhang XilaiZhang merged commit d5623b5 into flutter:flutter-3.13-candidate.0 Sep 6, 2023
XilaiZhang added a commit that referenced this pull request Sep 6, 2023
@XilaiZhang @godofredoc
[release cherrypick] Remove cirrus tests from the flutter framework (#…
95c954e 
…134157)

cp: #133575

Cirrus tests are removed in favor of the LUCI ones.

context:
#133602 (comment)

Co-authored-by: godofredoc <[email protected]>
XilaiZhang added a commit that referenced this pull request Sep 6, 2023
@XilaiZhang @godofredoc
[release CP] Remove cirrus tests from the flutter framework. (#134161)
3ada52e 
cp to beta:
cp: #133575

Cirrus tests are removed in favor of the LUCI ones.

context:
#133602 (comment)

Co-authored-by: godofredoc <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
d5623b520 [CP] handle exceptions raised while searching for configure…
449e54d 
…d android studio (flutter/flutter#133602)
@andrewkolos andrewkolos deleted the cp-handle-fs-exception-in-doctor branch April 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkolos @christopherfujino @XilaiZhang