Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change gradle lockfile generation script to use --config-only flag #132967

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Change gradle lockfile generation script to use --config-only flag #132967

merged 1 commit into from
Aug 21, 2023

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Aug 21, 2023 •
edited
Loading

The generate_gradle_lockfiles.dart script was generating the gradle wrapper by building a flavor that didn't exist. In the time since the script was written, the --config-only flag was created and should be used instead.

Context #132406 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall mentioned this pull request Aug 21, 2023
Merged
8 tasks
@gmackall gmackall marked this pull request as ready for review August 21, 2023 17:33
@gmackall gmackall requested a review from a team August 21, 2023 17:34
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@reidbaker
Copy link
Contributor

It is probably outside the scope of this pr but consider filing an issue for us to test the lockfile generation script in presubmit so we can know when it breaks.

@Hixie
Copy link
Contributor

Hixie commented Aug 21, 2023

test-exempt: code refactor with no semantic change

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2023
@auto-submit auto-submit bot merged commit 505f9d8 into flutter:master Aug 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
505f9d8 Change gradle lockfile generation script to use --config-only…
8ebbb0d 
… flag (flutter/flutter#132967)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
Roll Flutter from 5e6d88d to 54c98d7 (24 revisions) (#4754)
c730a90 
flutter/flutter@5e6d88d...54c98d7

2023-08-22 [email protected] Roll Flutter Engine from 447981acbf36 to f5f099a4a5e3 (1 revision) (flutter/flutter#133035)
2023-08-22 [email protected] Roll Flutter Engine from 5e84d733ef67 to 447981acbf36 (2 revisions) (flutter/flutter#133031)
2023-08-22 [email protected] Roll Flutter Engine from e183e8a94093 to 5e84d733ef67 (1 revision) (flutter/flutter#133030)
2023-08-22 [email protected] Roll Flutter Engine from 454e0e35f8e4 to e183e8a94093 (2 revisions) (flutter/flutter#133026)
2023-08-22 [email protected] Roll Flutter Engine from 857840db5574 to 454e0e35f8e4 (1 revision) (flutter/flutter#133020)
2023-08-22 [email protected] Roll Flutter Engine from 1ab054967c1d to 857840db5574 (2 revisions) (flutter/flutter#133018)
2023-08-22 [email protected] Roll Flutter Engine from 5a292e42a593 to 1ab054967c1d (1 revision) (flutter/flutter#133014)
2023-08-22 [email protected] Fix visual overflow for SliverMainAxisGroup (flutter/flutter#132989)
2023-08-22 [email protected] Roll Flutter Engine from e5929d83e9b7 to 5a292e42a593 (3 revisions) (flutter/flutter#133010)
2023-08-22 [email protected] Always require `--local-engine-host` if `--local-engine` (flutter/flutter#133003)
2023-08-22 [email protected] Roll Flutter Engine from 55b84268f2a6 to e5929d83e9b7 (3 revisions) (flutter/flutter#133005)
2023-08-21 [email protected] Roll Flutter Engine from e5f690b829e5 to 55b84268f2a6 (1 revision) (flutter/flutter#133000)
2023-08-21 [email protected] Add deleteBackwardByDecomposingPreviousCharacter mapping for tests (flutter/flutter#132919)
2023-08-21 [email protected] Roll Flutter Engine from fc75109c3a1e to e5f690b829e5 (1 revision) (flutter/flutter#132996)
2023-08-21 [email protected] Roll Flutter Engine from 2388b9db2be7 to fc75109c3a1e (3 revisions) (flutter/flutter#132992)
2023-08-21 [email protected] Roll Flutter Engine from 210f5a8aa245 to 2388b9db2be7 (6 revisions) (flutter/flutter#132986)
2023-08-21 [email protected]  Update `ExpansionPanel` example for the updated `expansionCallback` callback (flutter/flutter#132837)
2023-08-21 [email protected] Change gradle lockfile generation script to use --config-only flag (flutter/flutter#132967)
2023-08-21 [email protected] Roll Flutter Engine from 0290d0bd79ee to 210f5a8aa245 (1 revision) (flutter/flutter#132973)
2023-08-21 [email protected] Docs on iOS's directional quote characters (flutter/flutter#132869)
2023-08-21 [email protected] Bump memory usage for flutter gallery (flutter/flutter#132968)
2023-08-21 [email protected] When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK (flutter/flutter#127456)
2023-08-21 [email protected] Roll Flutter Engine from a9b00783bc7c to 0290d0bd79ee (1 revision) (flutter/flutter#132962)
2023-08-21 [email protected] Roll Packages from 4c16f3e to e26f3b9 (5 revisions) (flutter/flutter#132960)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
505f9d8 Change gradle lockfile generation script to use --config-only…
6111502 
… flag (flutter/flutter#132967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmackall @reidbaker @Hixie