Fix Chip.shape's side is not used when provided in Material 3

[TahaTesser]

fixes Chip border side color not working in Material3

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
        chipTheme: const ChipThemeData(
            // shape: RoundedRectangleBorder(
            //   side: BorderSide(color: Colors.amber),
            //   borderRadius: BorderRadius.all(Radius.circular(12)),
            // ),
            // side: BorderSide(color: Colors.red),
            ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          // side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),
    );
  }
}

---

Before

When RawChip.shape is provided with a BorderSide.

      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          label: Text('Chip'),
        ),
      ),

When RawChip.shape is provided with a BorderSide and also RawChip.side is provided. The RawChip.side overrides the shape's side.

      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),

---

After

When RawChip.shape is provided with a BorderSide.

      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          label: Text('Chip'),
        ),
      ),

When RawChip.shape is provided with a BorderSide and also RawChip.side is provided. The RawChip.side overrides the shape's side.

      body: Center(
        child: RawChip(
          shape: RoundedRectangleBorder(
            side: BorderSide(color: Colors.amber),
            borderRadius: BorderRadius.all(Radius.circular(12)),
          ),
          side: BorderSide(color: Colors.red),
          label: Text('Chip'),
        ),
      ),

---

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[HansMuller]

LGTM

[HansMuller]

The source of the problem appears to be https://github.com/flutter/flutter/pull/132941/files#diff-182e52332f7e266b854b25f1bf7c3d1fa20698ebcd30276bb11abc310bac6c24L2237 which removes the default border for the base Chip class in M3. This is a breaking change although it doesn't appear to have affected any of the external customer tests.

[TahaTesser]

The source of the problem appears to be https://github.com/flutter/flutter/pull/132941/files#diff-182e52332f7e266b854b25f1bf7c3d1fa20698ebcd30276bb11abc310bac6c24L2237 which removes the default border for the base Chip class in M3. This is a breaking change although it doesn't appear to have affected any of the external customer tests.

Thanks for the update! I will look into this change and add regression tests within the framework tests.