Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ios_app_with_extensions_test to host only #131441

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Move ios_app_with_extensions_test to host only #131441

merged 7 commits into from
Jul 28, 2023

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Jul 27, 2023 •
edited
Loading

ios_app_with_extensions_test only builds the artifact, it does not need a device to run.
This PR adds the copies of these tests to run hostonly. When the new tests pass in post submit, we should remove the old ones.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from keyonghan July 27, 2023 22:15
keyonghan
keyonghan approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023
@auto-submit auto-submit bot merged commit 3c8c300 into flutter:master Jul 28, 2023
@cyanglaz cyanglaz deleted the move_app_with_extension_to_host branch July 28, 2023 15:45
@keyonghan keyonghan mentioned this pull request Jul 28, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2023
@engine-flutter-autoroll
3c8c300 Move ios_app_with_extensions_test to host only (flutter/flutt…
fd9cf2d 
…er#131441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 29, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2023
@engine-flutter-autoroll
3c8c300 Move ios_app_with_extensions_test to host only (flutter/flutt…
249a3fc 
…er#131441)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 29, 2023
@engine-flutter-autoroll
Roll Flutter from e81907e to c2b40ca (24 revisions) (#4588)
dd45a2a 
flutter/flutter@e81907e...c2b40ca

2023-07-29 [email protected] Roll Flutter Engine from 24ccd8fffbcb to 5184062f7543 (2 revisions) (flutter/flutter#131554)
2023-07-29 [email protected] Roll Flutter Engine from 90bc483524fe to 24ccd8fffbcb (1 revision) (flutter/flutter#131540)
2023-07-29 [email protected] Roll Flutter Engine from 27128f29a066 to 90bc483524fe (2 revisions) (flutter/flutter#131535)
2023-07-29 [email protected] Roll Flutter Engine from 69b5b77edaf7 to 27128f29a066 (1 revision) (flutter/flutter#131533)
2023-07-29 [email protected] Roll Flutter Engine from b854fdea2715 to 69b5b77edaf7 (1 revision) (flutter/flutter#131532)
2023-07-29 [email protected] Roll Flutter Engine from 0a5b2f521539 to b854fdea2715 (1 revision) (flutter/flutter#131530)
2023-07-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.0 to 2.21.2 (flutter/flutter#131512)
2023-07-29 [email protected] Roll Flutter Engine from f5c17f0e2406 to 0a5b2f521539 (2 revisions) (flutter/flutter#131529)
2023-07-29 [email protected] Roll Flutter Engine from b4bf592279d6 to f5c17f0e2406 (1 revision) (flutter/flutter#131525)
2023-07-28 [email protected] Roll Flutter Engine from da3721adba65 to b4bf592279d6 (2 revisions) (flutter/flutter#131519)
2023-07-28 [email protected] Roll Flutter Engine from aa1278eb7b84 to da3721adba65 (5 revisions) (flutter/flutter#131514)
2023-07-28 [email protected] Reland - Fix floating SnackBar throws when FAB is on the top (flutter/flutter#131475)
2023-07-28 [email protected] Device discovery output cleanup (flutter/flutter#131223)
2023-07-28 [email protected] Roll Flutter Engine from 182e1189873b to aa1278eb7b84 (2 revisions) (flutter/flutter#131500)
2023-07-28 [email protected] Update `BottomSheet.enableDrag`  & `BottomSheet.showDragHandle` docs for animation controller (flutter/flutter#131484)
2023-07-28 [email protected] Deprecate `useMaterial3` parameter in `ThemeData.copyWith()` (flutter/flutter#131455)
2023-07-28 [email protected] Roll Flutter Engine from 73615d66b2fe to 182e1189873b (2 revisions) (flutter/flutter#131492)
2023-07-28 [email protected] Add `CheckedPopupMenuItemâ��.labelTextStyle` and update default text style for Material 3 (flutter/flutter#131060)
2023-07-28 [email protected] Remove obsolete `complex_layout_ios__compile.dart` test (flutter/flutter#131487)
2023-07-28 [email protected] Roll Flutter Engine from e97014c71014 to 73615d66b2fe (3 revisions) (flutter/flutter#131485)
2023-07-28 [email protected] Shared state to support multi screen inspection  (flutter/flutter#129452)
2023-07-28 [email protected] Roll Packages from f4ae933 to 10aab44 (4 revisions) (flutter/flutter#131483)
2023-07-28 [email protected] Move ios_app_with_extensions_test to host only (flutter/flutter#131441)
2023-07-28 [email protected] Update `Card.color` documentation for Material 3 (flutter/flutter#131468)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@LouiseHsu
Move ios_app_with_extensions_test to host only (flutter#131441)
8bcf7b8 
`ios_app_with_extensions_test` only builds the artifact, it does not need a device to run.
This PR adds the copies of these tests to run hostonly. When the new tests pass in post submit, we should remove the old ones.
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 1, 2023 •
edited
Loading

The tests are failing at:

[2023-07-28 19:09:21.388161] [STDOUT] stderr: [   +1 ms] CocoaPods not installed or not in valid state.
[2023-07-28 19:09:21.388374] [STDOUT] stderr: [        ] 
[2023-07-28 19:09:21.388386] [STDOUT] stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
[2023-07-28 19:09:21.388393] [STDOUT] stderr:            #1      CocoaPods.processPods (package:flutter_tools/src/macos/cocoapods.dart:168:9)
[2023-07-28 19:09:21.388400] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388407] [STDOUT] stderr:            #2      processPodsIfNeeded (package:flutter_tools/src/macos/cocoapod_utils.dart:43:30)
[2023-07-28 19:09:21.388414] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388420] [STDOUT] stderr:            #3      buildXcodeProject (package:flutter_tools/src/ios/mac.dart:244:3)
[2023-07-28 19:09:21.388427] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388433] [STDOUT] stderr:            #4      _BuildIOSSubCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:651:37)
[2023-07-28 19:09:21.388439] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388446] [STDOUT] stderr:            #5      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1322:27)
[2023-07-28 19:09:21.388452] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388458] [STDOUT] stderr:            #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
[2023-07-28 19:09:21.388464] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388471] [STDOUT] stderr:            #7      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
[2023-07-28 19:09:21.388477] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388483] [STDOUT] stderr:            #8      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:9)
[2023-07-28 19:09:21.388490] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388496] [STDOUT] stderr:            #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
[2023-07-28 19:09:21.388503] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388509] [STDOUT] stderr:            #10     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:285:5)
[2023-07-28 19:09:21.388515] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388521] [STDOUT] stderr:            #11     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:115:9)
[2023-07-28 19:09:21.388528] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388534] [STDOUT] stderr:            #12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
[2023-07-28 19:09:21.388540] [STDOUT] stderr:            <asynchronous suspension>
[2023-07-28 19:09:21.388546] [STDOUT] stderr:            #13     main (package:flutter_tools/executable.dart:90:3)
[2023-07-28 19:09:21.388552] [STDOUT] stderr:            <asynchronous suspension>

Cocoapods are installed on the machine, I'm not sure why it failed. The failure might not be related to if a device is connected.

@cyanglaz cyanglaz mentioned this pull request Aug 1, 2023
Closed
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@vashworth
Move ios_app_with_extensions_test to host only (flutter#131441)
6ae5c63 
`ios_app_with_extensions_test` only builds the artifact, it does not need a device to run.
This PR adds the copies of these tests to run hostonly. When the new tests pass in post submit, we should remove the old ones.
@cyanglaz cyanglaz mentioned this pull request Aug 2, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Aug 3, 2023
remove Mac_ios ios_app_with_extensions_test (#131806)
13ff16c 
Removing the extension test that unnecessarily running with devices.

The new hostonly tests were added in #131441
@jmagman jmagman mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyanglaz @keyonghan