Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Colors.fromARGB() to Colors.fromRGBA() #5289

Closed
dvdwasibi opened this issue Aug 8, 2016 · 2 comments
Closed

Change Colors.fromARGB() to Colors.fromRGBA() #5289

dvdwasibi opened this issue Aug 8, 2016 · 2 comments

Comments

@dvdwasibi
Copy link
Contributor

This is a potential usability improvement.

  • Usually when designers/developers specify color, the order is RGBA.
  • This is also true for CSS.
  • Alpha value is also usually from 0-100 or 0.0-1.0 instead from 0-255.
  • This will reduce cognitive overhead for designers/developers coming from the web world.

Examples:
Chrome:
screen shot 2016-08-08 at 12 07 43 pm

Sketch:
screen shot 2016-08-08 at 12 09 23 pm
@sethladd
Copy link
Contributor

sethladd commented Aug 8, 2016

Thanks for filing! Dupe of #5205 :)

@sethladd sethladd closed this as completed Aug 8, 2016
aam added a commit to aam/flutter that referenced this issue May 17, 2018
@aam
Roll engine to 40a3712
cd79ec7 
Changes since last roll:
```
40a3712 Remove the content handler for its move to topaz. (flutter#5289)
a262da4 Roll src/third_party/skia/ c06754b04..000e00df1 (12 commits; 1 trivial rolls) (flutter#5288)
f7eab94 Roll src/third_party/skia/ bd74e6a02..c06754b04 (1 commit) (flutter#5287)
597fa9e Delegate AppDelegate life-cycle callbacks to plugins via separate object (flutter#5173)
ef0915c update docs for Path.getBounds (flutter#5261)
bb1736b Roll src/third_party/skia/ 15f1761d9..bd74e6a02 (1 commit; 1 trivial rolls) (flutter#5286)
8c9558b Roll src/third_party/skia/ ed4921b9d..15f1761d9 (1 commit) (flutter#5285)
5cbfa95 Roll src/third_party/skia/ 05da1c16d..ed4921b9d (1 commit) (flutter#5284)
919e8c2 Support for TwoPointConical gradients (flutter#5275)
cdd7e08 Roll src/third_party/skia/ 94f585ed0..05da1c16d (9 commits; 1 trivial rolls) (flutter#5283)
```
aam added a commit that referenced this issue May 17, 2018
@aam
Roll engine to 40a3712 (#17702)
8a83d0d 
* Roll engine to 40a3712

Changes since last roll:
```
40a3712 Remove the content handler for its move to topaz. (#5289)
a262da4 Roll src/third_party/skia/ c06754b04..000e00df1 (12 commits; 1 trivial rolls) (#5288)
f7eab94 Roll src/third_party/skia/ bd74e6a02..c06754b04 (1 commit) (#5287)
597fa9e Delegate AppDelegate life-cycle callbacks to plugins via separate object (#5173)
ef0915c update docs for Path.getBounds (#5261)
bb1736b Roll src/third_party/skia/ 15f1761d9..bd74e6a02 (1 commit; 1 trivial rolls) (#5286)
8c9558b Roll src/third_party/skia/ ed4921b9d..15f1761d9 (1 commit) (#5285)
5cbfa95 Roll src/third_party/skia/ 05da1c16d..ed4921b9d (1 commit) (#5284)
919e8c2 Support for TwoPointConical gradients (#5275)
cdd7e08 Roll src/third_party/skia/ 94f585ed0..05da1c16d (9 commits; 1 trivial rolls) (#5283)
```

* Include more changes(reverts and a fix)
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sethladd @dvdwasibi