Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] simplify adding new benchmarks to Golem #4551

Closed
yjbanov opened this issue Jun 14, 2016 · 1 comment
Closed

[dashboard] simplify adding new benchmarks to Golem #4551

yjbanov opened this issue Jun 14, 2016 · 1 comment
Assignees
@yjbanov

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Jun 14, 2016

Currently to add a new benchmark one needs to perform 4 steps:

  • write the benchmark
  • add benchmark to Golem (via a CL)
  • add benchmark to dashboard_box (via a PR)
  • add benchmark to Firebase-to-Golem syncer (a PR + reboot the syncer server)

The last step could be made unnecessary if a task's __metadata__ contained all the information needed to submit to Golem. Then the syncer wouldn't need a hard-coded list of benchmarks to submit, but simply read it off the __metadata__ field.
@yjbanov yjbanov self-assigned this Jun 14, 2016
@yjbanov yjbanov closed this as completed Jun 14, 2016
cdotstout pushed a commit to cdotstout/flutter that referenced this issue Apr 3, 2018
@Hixie
Make Canvas cullRect optional and make Rect.largest a static field. (f…
6fee265 
…lutter#4551)

Fixes flutter#7201.

The change from `new Rect.largest()` to `Rect.largest` saves a few
allocations since we'll be using these with every Canvas.
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yjbanov yjbanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yjbanov