Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine failing to roll to framework on new analyzer lint. #133922

Closed
zanderso opened this issue Sep 2, 2023 · 2 comments
Closed

Engine failing to roll to framework on new analyzer lint. #133922

zanderso opened this issue Sep 2, 2023 · 2 comments
Labels
dependency: dart Dart team may need to help us P0 Critical issues such as a build break or regression team-engine Owned by Engine team

Comments

@zanderso
Copy link
Member

zanderso commented Sep 2, 2023

Starting with the roll attempt at #133916

https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/63719/overview

Command: bin/flutter analyze --flutter-repo
Command exited with exit code 1 but expected zero exit code.
Working directory: /b/s/w/ir/x/w/Á flutter sdk/.
stdout and stderr output:
Analyzing Á flutter sdk...                                      

   info • Unnecessary constructor invocation • packages/flutter/lib/src/widgets/framework.dart:3113:75 • prefer_collection_literals

That message is for this line: https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/widgets/framework.dart#L3113

Scanning the commits, this one looks interesting:

https://dart.googlesource.com/sdk.git/+/cd8a3370e7d854ded526329178eb8c046917ddf7

That rolled into the engine at flutter/engine#45412

@srawlins

@zanderso zanderso added dependency: dart Dart team may need to help us P0 Critical issues such as a build break or regression team-engine Owned by Engine team labels Sep 2, 2023
zanderso added a commit that referenced this issue Sep 2, 2023
zanderso added a commit that referenced this issue Sep 2, 2023
@srawlins
Copy link
Contributor

srawlins commented Sep 3, 2023

Sorry about that, @zanderso ; thanks for looking into the fix!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependency: dart Dart team may need to help us P0 Critical issues such as a build break or regression team-engine Owned by Engine team
Projects
None yet
Development

No branches or pull requests

3 participants