Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

[CP-stable][web] Use eventTarget when computing pointer offset #57246

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[CP-stable][web] Use eventTarget when computing pointer offset #57246

merged 1 commit into from
Jan 9, 2025

Conversation

flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented Dec 17, 2024 •
edited by mdebbar
Loading

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Links:

flutter/flutter#160155
flutter/flutter#159804

Changelog Description:

Work around this Chromium bug: https://issues.chromium.org/issues/382473107

Impact Description:

This bug is causing issues when mouse interacts with text fields in Flutter Web.

Workaround:

This CP is the workaround.

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

  • Open a Flutter Web app in Chrome.
  • Click on a text field.
  • Move the mouse over the text field.
  • There should be no errors in the console.

@flutteractionsbot flutteractionsbot added the cp: review add the cp request to the review queue of release engineers label Dec 17, 2024
@flutteractionsbot
Copy link
Author

@mdebbar please fill out the PR description above, afterwards the release team will review this request.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Dec 17, 2024
@mdebbar mdebbar mentioned this pull request Dec 17, 2024
Closed
@Macacoazul01 Macacoazul01 mentioned this pull request Dec 18, 2024
Closed
@Kemerd
Copy link

Kemerd commented Dec 18, 2024

Merge pls

@EliaTolin
Copy link

Please merge!

@kyam28
Copy link

kyam28 commented Dec 21, 2024 •
edited
Loading

There is a scrolling bug in Flutter 3.24 on iOS 18.2, so I want to upgrade to 3.27 quickly, but this bug is preventing the upgrade to 3.27. This is a critical bug for those developing Flutter Web, and I hope it gets merged soon.
It should be treated as a hotfix level issue.

@mosheduminer
Copy link

What's blocking this? I see the Mac mac_unopt check failed - surely the failures there are unrelated given this is a web change (and those failures would seem to have little do with this change)?

@lishaduck lishaduck mentioned this pull request Jan 7, 2025
Merged
6 tasks
lishaduck added a commit to PHS-TSA/nexus that referenced this pull request Jan 8, 2025
@lishaduck
chore: switch to master channel
edf0507 
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
@lishaduck lishaduck mentioned this pull request Jan 8, 2025
Merged
6 tasks
lishaduck added a commit to PHS-TSA/nexus that referenced this pull request Jan 8, 2025
@lishaduck
chore: switch to master channel
ce76437 
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
lishaduck added a commit to PHS-TSA/nexus that referenced this pull request Jan 8, 2025
@lishaduck
chore: switch to master channel
575ac6c 
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
lishaduck added a commit to PHS-TSA/nexus that referenced this pull request Jan 8, 2025
@lishaduck
chore: switch to master channel
a5af481 
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
yjbanov
yjbanov approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lishaduck added a commit to PHS-TSA/nexus that referenced this pull request Jan 9, 2025
@lishaduck
chore: switch to master channel
ad1c7ab 
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
lishaduck added a commit to PHS-TSA/nexus that referenced this pull request Jan 9, 2025
@lishaduck
chore: switch to master channel
a5b6a16 
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
@ZoftPranav
Copy link

Please fix this soon...

@j-fbriere
Copy link

j-fbriere commented Jan 9, 2025 •
edited
Loading

Please merge! I see the Mac mac_unopt check now has succeeded. All checks have passed.

github-merge-queue bot pushed a commit to PHS-TSA/nexus that referenced this pull request Jan 9, 2025
@lishaduck
chore: switch to master channel (#71)
f6ee95a 
Awaiting CP (flutter/engine#57246) of flutter/engine#56949 to stable.
@kevmoo
Copy link
Contributor

kevmoo commented Jan 9, 2025

We're waiting on the release engineering team to pick this up now. Thanks for your patience.

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025
@auto-submit auto-submit bot merged commit 9c0d322 into flutter:flutter-3.27-candidate.0 Jan 9, 2025
28 checks passed
@zoheirallafzadeh
Copy link

I changed to channel master...
"Flutter 3.28.0-2.0.pre.38665"
And it is solved

@felipeduarte26
Copy link

We're waiting on the release engineering team to pick this up now. Thanks for your patience.

thankss

@zoheirallafzadeh
Copy link

I changed to channel master... "Flutter 3.28.0-2.0.pre.38665" And it is solved

I encountered several other problems in this version.

I went back to <<Flutter 3.27.2 • channel stable>>
which was published last week...

That problem has been resolved and does not have the new problems in version 3.28.0-2.0.pre.38665.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: review add the cp request to the review queue of release engineers platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.