Reland 'Delete stale package_config.json in gclient sync hook' #57218
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
goderbauer
added
the
autosubmit
Sounds good. Added the autosubmit label. |
…160376) flutter/engine@d373a93...0dfbd04 2024-12-16 [email protected] Roll Skia from 8c1e2bf9492c to 8054b098b5cd (5 revisions) (flutter/engine#57197) 2024-12-16 [email protected] Reland 'Delete stale package_config.json in gclient sync hook' (flutter/engine#57218) 2024-12-16 [email protected] docs: Fix RGB565 format documentation and bit masks (flutter/engine#57210) 2024-12-16 [email protected] [Impeller] disable AHB swapchains on all platforms. (flutter/engine#57213) 2024-12-16 [email protected] [Impeller] fix Adreno precision issue in gaussian downsample. (flutter/engine#57212) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er/engine#57218) flutter/engine#57195 was reverted because it tried to delete non-existing files. This adds a check to only attempt to delete the file if it exists.
#57195 was reverted because it tried to delete non-existing files. This adds a check to only attempt to delete the file if it exists.