Add RoundSuperellipse to drawing OP #57205
Draft
+236
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -329,6 +329,11 @@ void DisplayListMetalComplexityCalculator::MetalHelper::drawDiffRoundRect( | |||
| AccumulateComplexity(complexity); | |||
| } | |||
|
|
|||
| void DisplayListMetalComplexityCalculator::MetalHelper::drawRoundSuperellipse( | |||
| const DlRoundSuperellipse& rse) { | |||
| // TODO(dkwingsmt): implement | |||
There was a problem hiding this comment.
Just FYI you do not need to implement this, as the complexity calculator is irrelevant for Impeller and never used.
There was a problem hiding this comment.
Ah, I see. Does it mean I should leave this unimplemented since round superellipse is not supported in Skia?
There was a problem hiding this comment.
I would vote for leaving it unimplemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.