Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Disable RBE in the GN flags for wasm_release builds in the linux_web_engine builder #57204

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jason-simmons
Copy link
Member

RBE is not supported for this build. Starting the RBE proxy adds unnecessary overhead, and the attempt to use RBE will cause the build recipe to request too many parallel jobs in Ninja.

…engine builder

RBE is not supported for this build.  Starting the RBE proxy adds unnecessary overhead, and the attempt to use RBE will cause the build recipe to request too many parallel jobs in Ninja.
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@auto-submit auto-submit bot merged commit d373a93 into flutter:main Dec 16, 2024
33 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 16, 2024
…160356)

flutter/engine@330210f...d373a93

2024-12-16 [email protected] Disable RBE in the GN
flags for wasm_release builds in the linux_web_engine builder
(flutter/engine#57204)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…engine builder (flutter/engine#57204)

RBE is not supported for this build.  Starting the RBE proxy adds unnecessary overhead, and the attempt to use RBE will cause the build recipe to request too many parallel jobs in Ninja.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants