Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] update deps and pubspecs for the new locations of package:matcher, package:collection, and package:boolean_selector #56107

Merged

Conversation

devoncarew
Copy link
Member

Update the deps and pubspec files for the new SoT locations for:

  • package:matcher (dart-lang/test)
  • package:collection (dart-lang/core)
  • package:boolean_selector (dart-lang/tools)

See also issue dart-lang/sdk#56591.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…her, package:collection, and package:boolean_selector
@github-actions github-actions bot added platform-web Code specifically for the web engine platform-fuchsia labels Oct 24, 2024
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2024
@auto-submit auto-submit bot merged commit 88716d8 into flutter:main Oct 24, 2024
35 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 24, 2024
…ckage:matcher, package:collection, and package:boolean_selector (flutter/engine#56107)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 25, 2024
…157567)

flutter/engine@b8b28c8...88716d8

2024-10-24 [email protected] [deps] update deps and pubspecs for the new locations of package:matcher, package:collection, and package:boolean_selector (flutter/engine#56107)
2024-10-24 [email protected] Roll Dart SDK from 7d218a25e8bf to 3067d697ae26 (3 revisions) (flutter/engine#56106)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…her, package:collection, and package:boolean_selector (flutter/engine#56107)

Update the deps and pubspec files for the new SoT locations for:

- package:matcher (dart-lang/test)
- package:collection (dart-lang/core)
- package:boolean_selector (dart-lang/tools)

See also issue dart-lang/sdk#56591. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-fuchsia platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants