-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-window satellites on Windows #56094
base: main
Are you sure you want to change the base?
Conversation
Hey @hbatagelo! We’re excited to see all the progress on the multi-window project, thank you! Sharing from an offline sync for folks following these developments: Before reviewing these pull requests, we’re going to ensure we finish the design review so we are aligned on the final APIs and where they will live. Please see the linked design document and provide feedback. We’ll discuss this feedback in a future Dash Forum, these typically occur weekly and are open to all members of flutter-hackers. The date for this forum has not been set yet, as we are waiting for one of the reviewers to return from being out of office. Once they are back, we will set a date and communicate it on the Discord as usual. Thanks very much for your patience, and for all of the work here! |
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
Design doc: https://docs.google.com/document/d/1eQG-IS7r4_S9_h50MY_hSGwUVtgSTRSLzu7MLzPNd2Y/edit?tab=t.0
This PR is a part of a group of PRs. Going from first to last, these must be merged in the following order:
See also the corresponding framework PRs for multi-win support, starting from: flutter/flutter#157515
What's New
This pull request adds support for multi-window satellites in the Windows embedder.
A new method is available in the
flutter/windowing
channel:createSatellite(Map)
Map
must contain the following key-value pairs:String
)"parent"
int
)"size"
List<int>
)"anchorRect"
null
, the child window will be positioned relative to the window frame of the parent (List<int>
)"positionerParentAnchor"
WindowPositionerAnchor
)"positionerChildAnchor"
WindowPositionerAnchor
)"positionerOffset"
List<int>
)"positionerConstraintAdjustment"
WindowPositioner::ConstraintAdjustment
, defining the adjustments to apply if the child window doesn't fit in the available space. The order of precedence is: 1) Flip, 2) Slide, 3) Resize (int
)On success, a
Map
is returned with the following key-value pairs:String
)"viewId"
int
)"archetype"
WindowArchetype::satellite
"size"
List<int>
)"parentViewId"
int
)If the method fails, a
PlatformException
is thrown.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.