This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Prefix gen_shapshot build invocation with time based on the current platform.
#55633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
reviewed
Oct 3, 2024
| @@ -63,6 +63,9 @@ group("generate_snapshot_bins") { | |||
| # See: `bin_to_linkable` rules below that build these outputs into linkable form | |||
| # See: https://github.com/flutter/flutter/wiki/Flutter-engine-operation-in-AOT-Mode | |||
| compiled_action("generate_snapshot_bin") { | |||
| # TODO(https://github.com/flutter/flutter/issues/154437). | |||
| prefix_with_time_cmd = true | |||
There was a problem hiding this comment.
Does this flag need to be added to https://github.com/flutter/buildroot repo first?
There was a problem hiding this comment.
Oh shoot, I thought I had sent the buildroot patch, let me send you that first!
There was a problem hiding this comment.
There was a problem hiding this comment.
Rolled buildroot in this PR as well.
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
aam
approved these changes
Oct 3, 2024
matanlurey
added a commit
to flutter/buildroot
that referenced
this pull request
Oct 3, 2024
Work on debugging flutter/flutter#154437. Must land and roll into flutter/engine before flutter/engine#55633.
|
Looks like it assumed the executable was local, versus on the PATH: I'll... look at this again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on debugging flutter/flutter#154437.