Reverts "Reland: Framework wide color (#54415) (#54737)" #54885
Merged
+80
−811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #54737
Initiated by: chingjun
Reason for reverting: Breaking internal tests. See b/363125155
Original PR Author: gaaclarke
Reviewed By: {matanlurey, jonahwilliams}
This change reverts the following previous change:
This PR was reverted because it requires a manual roll into the framework.
issue: flutter/flutter#127855
integration test: #54415
This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8
The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this:
implements Color
flutter#153938 which will make CupertinoDynamicColor implement ColorHere are follow up PRs:
There are some things that have been left as follow up PRs since they are technically breaking:
lerp
hasn't been updated to take advantage of the higher bit depthoperator==
hasn't been updated to take advantage of the higher bit depthhashCode
hasn't been updated to take advantage of the higher bit depthalphaBlend
hasn't been updated to take advantage of the higher bit depthtoString
hasn't been updated to take advantage of the higher bit depthPre-launch Checklist
///
).