Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "Reland: Framework wide color (#54415) (#54737)" #54885

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Aug 30, 2024

Reverts: #54737

Initiated by: chingjun

Reason for reverting: Breaking internal tests. See b/363125155

Original PR Author: gaaclarke

Reviewed By: {matanlurey, jonahwilliams}

This change reverts the following previous change:
This PR was reverted because it requires a manual roll into the framework.

issue: flutter/flutter#127855
integration test: #54415

This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8

The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this:

  1. Land this PR
  2. Wait for it to roll into the Framework
  3. Land Switched CupertinoDynamicColor to implements Color flutter#153938 which will make CupertinoDynamicColor implement Color
  4. Land another engine PR that rips out the int storage: Removes the int storage from Color #54714

Here are follow up PRs:

  1. Changes DlColor to support wide gamut colors #54473 - changes DlColor so the wide gamut colors are rendered
  2. Hooks up framework wide gamut to engine wide gamut #54567 - Hooks up these changes to take advantage of wide DlColor
  3. Adds wide gamut framework test flutter#153319 - the integration test for the framework repo

There are some things that have been left as follow up PRs since they are technically breaking:

  1. The math on lerp hasn't been updated to take advantage of the higher bit depth
  2. operator== hasn't been updated to take advantage of the higher bit depth
  3. hashCode hasn't been updated to take advantage of the higher bit depth
  4. alphaBlend hasn't been updated to take advantage of the higher bit depth
  5. toString hasn't been updated to take advantage of the higher bit depth

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Aug 30, 2024
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Aug 30, 2024
@auto-submit auto-submit bot merged commit 9c3f66d into main Aug 30, 2024
7 checks passed
@auto-submit auto-submit bot deleted the revert_62154d33ad3ff4837cf603946b1d3f282aba36d4 branch August 30, 2024 04:31
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 30, 2024
…154385)

flutter/engine@da87db6...9c3f66d

2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: Framework wide color (#54415) (#54737)" (flutter/engine#54885)
2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Hooks up framework wide gamut to engine wide gamut (#54567)" (flutter/engine#54884)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#154385)

flutter/engine@da87db6...9c3f66d

2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: Framework wide color (flutter#54415) (flutter#54737)" (flutter/engine#54885)
2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Hooks up framework wide gamut to engine wide gamut (flutter#54567)" (flutter/engine#54884)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants