[Impeller] Compute correct-ish binding order for Vulkan. #53463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
chinmaygarde
approved these changes
Jun 18, 2024
| @@ -376,6 +376,8 @@ std::shared_ptr<RuntimeStageData::Shader> Reflector::GenerateRuntimeStageData() | |||
|
|
|||
| const auto& ubo = ubos[0]; | |||
|
|
|||
| size_t binding = | |||
There was a problem hiding this comment.
Ah, this is much nicer. The reflector reflects whats in the SPIRV instead of enforcing its own rules.
There was a problem hiding this comment.
its still broken though :)
| auto stage = stages[PlaygroundBackendToRuntimeStageBackend(GetBackend())]; | ||
|
|
||
| ASSERT_TRUE(stage->IsValid()); | ||
| switch (GetBackend()) { |
There was a problem hiding this comment.
if (GetBackends() != PlaygroundBackend::kVulkan) {
GTEST_SKIP() << "Only matters on Vulkan.";
}
| // found in the LICENSE file. | ||
|
|
||
| // sampler is specifically ordered before color. | ||
| uniform sampler2D u_texture; |
There was a problem hiding this comment.
Perhaps another test that flips this around?
|
agh. This is running on Vulkan but I need runtime stage vulkan. |
jonahwilliams
force-pushed
the
fixup_binding_order
branch
from
fbf6562 to
4ca1733
Compare
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 20, 2024
…150537) flutter/engine@f9c497f...dd37cef 2024-06-20 [email protected] Roll Skia from 79a7acc34939 to 199e1a49b091 (1 revision) (flutter/engine#53481) 2024-06-19 [email protected] [Impeller] Compute correct-ish binding order for Vulkan. (flutter/engine#53463) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for flutter/flutter#150324
Fixing binding offset of UBO if its not the first binding.
Tries to infer binding offset for sampler2D, but this may be incorrect if there is more than one sampler.