Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Update iOS CPU profiling instructions. #53440

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

chinmaygarde
Copy link
Member

Adds more instructions on how to setup FlameGraph. Some other subjective improvements to readability.

Adds more instructions on how to setup `FlameGraph`. Some other subjective improvements to readability.
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2024
@auto-submit auto-submit bot merged commit 78fdd06 into main Jun 18, 2024
27 checks passed
@auto-submit auto-submit bot deleted the ios_cpu_profiling branch June 18, 2024 02:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 18, 2024
…150403)

flutter/engine@1c4e5e2...78fdd06

2024-06-18 [email protected] [Impeller] Update iOS CPU profiling instructions. (flutter/engine#53440)
2024-06-18 [email protected] Roll Skia from 2b9bc16df969 to 2db8813a349d (4 revisions) (flutter/engine#53438)
2024-06-18 [email protected] Roll Dart SDK from 51bbba0da7d3 to 863f4d04575c (1 revision) (flutter/engine#53436)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants