[web] Add ability to customize font fallback download URL #51569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 23, 2024
…145630) flutter/engine@bc4fa43...8a51e12 2024-03-22 [email protected] Roll Skia from 10a460af3308 to 2e99e3a5445c (1 revision) (flutter/engine#51632) 2024-03-22 [email protected] Roll Dart SDK from a959c7def805 to ad26f4885bf4 (1 revision) (flutter/engine#51631) 2024-03-22 [email protected] [web] Add ability to customize font fallback download URL (flutter/engine#51569) 2024-03-22 [email protected] [skwasm] Use test fonts while in debugEmulateFlutterTesterEnvironment mode (flutter/engine#51630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives developers the ability to change the base URL to download fallback fonts from
fonts.gstatic.comto a URL of their choosing.Fixes flutter/flutter#132689
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.