This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Minor non-semantic refactors of ExternalTexturesFlutterActivity
#50845
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
reviewed
Feb 22, 2024
| @@ -92,7 +94,9 @@ public void waitUntilFlutterRendered() { | |||
| super.waitUntilFlutterRendered(); | |||
|
|
|||
| try { | |||
| firstFrameLatch.await(10, java.util.concurrent.TimeUnit.SECONDS); | |||
| if (!firstFrameLatch.await(10, java.util.concurrent.TimeUnit.SECONDS)) { | |||
| throw new RuntimeException("Timeout waiting for firstFrameLatch to signal"); | |||
There was a problem hiding this comment.
There is a class for timeouts: https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/TimeoutException.html
There was a problem hiding this comment.
It's a checked exception though, I don't think we actually want our callers to catch anything (it's not actionable).
...ario_app/android/app/src/main/java/dev/flutter/scenarios/ExternalTextureFlutterActivity.java
Show resolved
Hide resolved
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/50845, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 22, 2024
…143933) flutter/engine@7777480...9250bfd 2024-02-22 [email protected] Roll Skia from 0b55d78d32f9 to b9c16065b76d (1 revision) (flutter/engine#50861) 2024-02-22 [email protected] Roll Skia from cbdbcf9bebe6 to 0b55d78d32f9 (1 revision) (flutter/engine#50860) 2024-02-22 [email protected] Roll Fuchsia Linux SDK from dLhvv964txwnSlvNw... to j9cJ94K-T1i3u5xGh... (flutter/engine#50858) 2024-02-22 [email protected] Roll Skia from ec119f44e6b9 to cbdbcf9bebe6 (2 revisions) (flutter/engine#50857) 2024-02-22 [email protected] Roll Skia from 4aa97aca087c to ec119f44e6b9 (1 revision) (flutter/engine#50849) 2024-02-22 [email protected] [Impeller] Add StC color source/clip behavior + constexpr flag for enabling StC. (flutter/engine#50817) 2024-02-22 [email protected] Roll Skia from 3fd1a5a7c7c1 to 4aa97aca087c (2 revisions) (flutter/engine#50848) 2024-02-22 [email protected] Minor non-semantic refactors of `ExternalTexturesFlutterActivity` (flutter/engine#50845) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from dLhvv964txwn to j9cJ94K-T1i3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just getting rid of some IDE warnings/diagnostics before sending bigger PRs.