Resize the RenderTarget before creating and passing its Surface to the VirtualDisplay #49619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmccutchan
force-pushed
the
fix_virtual_display_android_28_earlier
branch
from
2464856 to
8c3c05d
Compare
…e VirtualDisplay This change ensures that we first set the default buffer size on the underlying SurfaceTexture before creating the Surface for it. This fixes a bug that only occurs on Android devices running 28 or older: see flutter/flutter#141068. This also removes some unnecessary init code and cleans up tests.
johnmccutchan
force-pushed
the
fix_virtual_display_android_28_earlier
branch
from
8c3c05d to
5c270b8
Compare
matanlurey
approved these changes
Jan 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2024
…face to the VirtualDisplay (flutter/engine#49619)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 9, 2024
…face to the VirtualDisplay (flutter/engine#49619)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 9, 2024
…141191) flutter/engine@036b39f...a35e3b0 2024-01-09 [email protected] Simplify PlatformViewRenderTarget interface (flutter/engine#49639) 2024-01-09 [email protected] Roll Skia from 05039d6ed8d8 to 8c8be76a62c0 (3 revisions) (flutter/engine#49638) 2024-01-09 [email protected] Skip flaky test on mac in http_disallow_http_connections_test.dart (flutter/engine#49635) 2024-01-09 [email protected] Resize the RenderTarget before creating and passing its Surface to the VirtualDisplay (flutter/engine#49619) 2024-01-09 [email protected] Migrate to Flutter mirrors for Google-owned Github repositories (flutter/engine#49203) 2024-01-09 [email protected] Roll Skia from ee263c34e03d to 05039d6ed8d8 (2 revisions) (flutter/engine#49636) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
The problem still occurs when I use flutter3.16.9 and Android 9 |
|
I want to know how to solve it in flutter3.16.9，thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that we first set the default buffer size on the underlying SurfaceTexture before creating the Surface for it.
This fixes a bug that only occurs on Android devices running 28 or older: see flutter/flutter#141068.
This also removes some unnecessary init code and cleans up tests.