-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] Disable raster stats service protocol. #47206
Merged
auto-submit
merged 1 commit into
flutter:main
from
jonahwilliams:disable_leaf_layer_tracing_impeller
Oct 23, 2023
Merged
[Impeller] Disable raster stats service protocol. #47206
auto-submit
merged 1 commit into
flutter:main
from
jonahwilliams:disable_leaf_layer_tracing_impeller
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
changed the title
[Impeller] disable raster stats service protocol.
[Impeller] Disable raster stats service protocol.
Oct 23, 2023
chinmaygarde
approved these changes
Oct 23, 2023
jonahwilliams
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Oct 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2023
…137085) flutter/engine@ef568c3...1ac3086 2023-10-23 [email protected] Roll Skia from d27ff651a99b to 8a0324990bf5 (1 revision) (flutter/engine#47229) 2023-10-23 [email protected] [Impeller] remove image upload workarounds. (flutter/engine#47209) 2023-10-23 [email protected] [Impeller] Disable raster stats service protocol. (flutter/engine#47206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
As far as I can tell, this functionality has _always_ been falling back to software rendering with Skia when Impeller was enabled. This is at best extremely misleading. Since I started putting Impeller specific objects in the display list it introduced crashes, and must be disabled. Fixes flutter/flutter#136847
jonahwilliams
added a commit
to jonahwilliams/engine
that referenced
this pull request
Nov 1, 2023
As far as I can tell, this functionality has _always_ been falling back to software rendering with Skia when Impeller was enabled. This is at best extremely misleading. Since I started putting Impeller specific objects in the display list it introduced crashes, and must be disabled. Fixes flutter/flutter#136847
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
As far as I can tell, this functionality has _always_ been falling back to software rendering with Skia when Impeller was enabled. This is at best extremely misleading. Since I started putting Impeller specific objects in the display list it introduced crashes, and must be disabled. Fixes flutter/flutter#136847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this functionality has always been falling back to software rendering with Skia when Impeller was enabled. This is at best extremely misleading. Since I started putting Impeller specific objects in the display list it introduced crashes, and must be disabled.
Fixes flutter/flutter#136847