This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Remove workaround for safely removing slots on Safari #47169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 20, 2023
…136987) flutter/engine@b27e1b3...4a65910 2023-10-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Multiview pipeline" (flutter/engine#47174) 2023-10-20 [email protected] Multiview pipeline (flutter/engine#44473) 2023-10-20 [email protected] Roll Skia from 9ffd5ef9a9ed to ca69b04f7dd2 (1 revision) (flutter/engine#47171) 2023-10-20 [email protected] Lower the severity of a log message (flutter/engine#47172) 2023-10-20 [email protected] [web] Remove workaround for safely removing slots on Safari (flutter/engine#47169) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Now that we want to support multi-view, we need to either: 1. Remove the workaround to safely remove slot elements in Safari, or 2. Fix it to support multi-view (can't use `flutterViewEmbedder.glassPaneShadow` anymore). According to [this comment](flutter/flutter#85816 (comment)), this is the right time to remove the workaround � I tested on Desktop Safari and iOS Safari and wasn't able to reproduce the crash reported in flutter/flutter#84832. Fixes flutter/flutter#85816 Part of flutter/flutter#134443
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we want to support multi-view, we need to either:
flutterViewEmbedder.glassPaneShadowanymore).According to this comment, this is the right time to remove the workaround 😄 I tested on Desktop Safari and iOS Safari and wasn't able to reproduce the crash reported in flutter/flutter#84832.
Fixes flutter/flutter#85816
Part of flutter/flutter#137287