Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Fix validation error about incorrect aspect on buffer to texture copies. #46078

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[Impeller] Fix validation error about incorrect aspect on buffer to texture copies. #46078

merged 1 commit into from
Sep 19, 2023

Conversation

chinmaygarde
Copy link
Member

This shows up when we try to set the contents of a depth of stencil image. The aspect was assumed to be color only because typical Impeller workloads have device-transient depth and stencil images. But the "stencil mask" test apparently does set the context directly. Besides, this is perfectly valid usage. This makes Vulkan resilient to said usage.

@chinmaygarde
[Impeller] Fix validation error about incorrect aspect on buffer to t…
6c559b5 
…exture copies.

This shows up when we try to set the contents of a depth of stencil
image. The aspect was assumed to be color only because typically
Impeller workloads have device-transient depth and stencil images. But
the stencil mask test apparently does set the context directly. This
makes Vulkan resilient to said usage.
@chinmaygarde chinmaygarde self-assigned this Sep 19, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

matanlurey
matanlurey approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'd prefer to see these enable tests on CI that were previously failing, otherwise there isn't a good way to know this really did anything.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2023
@auto-submit auto-submit bot merged commit 5a924a9 into flutter:main Sep 19, 2023
27 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
5a924a901 [Impeller] Fix validation error about incorrect aspect on b…
02aab79 
…uffer to texture copies. (flutter/engine#46078)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) (#…
6cf7ca0 
…135085)

flutter/engine@a7af55c...5a924a9

2023-09-19 [email protected] [Impeller] Fix validation error about incorrect aspect on buffer to texture copies. (flutter/engine#46078)
2023-09-19 [email protected] [Impeller] Affinity adjustments for Vulkan backend. (flutter/engine#46063)
2023-09-19 [email protected] [Impeller] Fix validation errors in RendererTest. (flutter/engine#46076)
2023-09-19 [email protected] Roll Skia from fe3568162721 to 1a8885b9e03c (6 revisions) (flutter/engine#46075)
2023-09-19 [email protected] [Impeller] adds hardware gate for wide gamut (flutter/engine#46051)
2023-09-19 [email protected] Properly transfer objects between the main thread and web worker. (flutter/engine#46061)
2023-09-19 [email protected] Made the warning about downgrading wide gamut happen at the correct time (flutter/engine#46064)
2023-09-19 [email protected] Conform to clang_tidy in `client_wrapper` headers. (flutter/engine#46058)
2023-09-19 [email protected] [Impeller] Adds unit test to make sure we can encode bgr101010xr to png. (flutter/engine#46007)
2023-09-19 [email protected] [ios] scenario test make parent view controller hide status bar (flutter/engine#46065)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Flutter Engine from a7af55c56aa6 to 5a924a9017d7 (10 revisions) (f…
0d00901 
…lutter#135085)

flutter/engine@a7af55c...5a924a9

2023-09-19 [email protected] [Impeller] Fix validation error about incorrect aspect on buffer to texture copies. (flutter/engine#46078)
2023-09-19 [email protected] [Impeller] Affinity adjustments for Vulkan backend. (flutter/engine#46063)
2023-09-19 [email protected] [Impeller] Fix validation errors in RendererTest. (flutter/engine#46076)
2023-09-19 [email protected] Roll Skia from fe3568162721 to 1a8885b9e03c (6 revisions) (flutter/engine#46075)
2023-09-19 [email protected] [Impeller] adds hardware gate for wide gamut (flutter/engine#46051)
2023-09-19 [email protected] Properly transfer objects between the main thread and web worker. (flutter/engine#46061)
2023-09-19 [email protected] Made the warning about downgrading wide gamut happen at the correct time (flutter/engine#46064)
2023-09-19 [email protected] Conform to clang_tidy in `client_wrapper` headers. (flutter/engine#46058)
2023-09-19 [email protected] [Impeller] Adds unit test to make sure we can encode bgr101010xr to png. (flutter/engine#46007)
2023-09-19 [email protected] [ios] scenario test make parent view controller hide status bar (flutter/engine#46065)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@chinmaygarde @harryterkelsen
[Impeller] Fix validation error about incorrect aspect on buffer to t…
6f424ec 
…exture copies. (#46078)

This shows up when we try to set the contents of a depth of stencil image. The aspect was assumed to be color only because typical Impeller workloads have device-transient depth and stencil images. But the "stencil mask" test apparently does set the context directly. Besides, this is perfectly valid usage. This makes Vulkan resilient to said usage.
felangel added a commit to shorebirdtech/engine that referenced this pull request Dec 11, 2023
@felangel @matanlurey
@cbracken @srujzs @skia-flutter-autoroll @goderbauer @gaaclarke @eyebrowsoffire @chinmaygarde @jonahwilliams @godofredoc @bdero @mdebbar @jason-simmons @sigurdm @yjbanov @dkwingsmt @johnmccutchan @dnfield @bleroux @whesse @zanderso @dependabot @keyonghan @kenzieschmoll @auto-submit @ianloic @bkonyi @harryterkelsen @kjlubick @knopp @loic-sharma @chunhtai @ajihyf @jwinarske @XilaiZhang @itsjustkevin @Jasguerrero @hellohuanlin @LouiseHsu @LinXunFeng
Rev to Flutter Engine 3.16.3 (#63)
3b35171 
* Add TODO(name) to comply with Clang Tidy. (#46057)

Partial work towards https://github.com/flutter/flutter/issues/134969.

* `FlutterMouse.*` -> `kFlutterMouse.*`, so we can lint header files. (#46056)

Partial work towards https://github.com/flutter/flutter/issues/134969.

---------

Co-authored-by: Chris Bracken <[email protected]>

* Implement JSObject instead of extending (#46070)

JSObject will have a factory constructor to create an object literal, so
you can't extend it as it will no longer have a generative constructor
(@staticInterop types can't have generative constructors).

* Roll Skia from 559a964f9f1b to fe3568162721 (5 revisions) (#46069)

https://skia.googlesource.com/skia.git/+log/559a964f9f1b..fe3568162721

2023-09-19 [email protected] [graphite] Switch signed unique ID iterators to unsigned.
2023-09-19 [email protected] Add "unsafe apis" toggle for Adapter in Graphite DawnTestContext
2023-09-19 [email protected] [skottie] Make text shaper header public
2023-09-19 [email protected] [graphite] Add option to disable cached glyph uploads.
2023-09-19 [email protected] [graphite] Use Dawn's dual-src blend coeffs when possible

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Enable strict-inference (#46062)

Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks

* [ios] scenario test make parent view controller hide status bar (#46065)

The parent view controller of FlutterViewController in `non_full_screen_flutter_view_platform_view` does not explicitly set the status bar hidden. iOS 17 will show the status bar causing the golden to be no deterministic. 

Part of https://github.com/flutter/flutter/issues/133207

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* [Impeller] Adds unit test to make sure we can encode bgr101010xr to png. (#46007)

fixes https://github.com/flutter/flutter/issues/133942

This is current blocked on the skia bug: https://g-issues.skia.org/issues/300986800
Depends on skia fix: https://skia-review.googlesource.com/c/skia/+/757816

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Conform to clang_tidy in `client_wrapper` headers. (#46058)

Partial work towards https://github.com/flutter/flutter/issues/134969.

All of these were auto-suggested by Clang, and mostly avoid unnecessary
copies.

* Made the warning about downgrading wide gamut happen at the correct time (#46064)

fixes https://github.com/flutter/flutter/issues/135033

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Properly transfer objects between the main thread and web worker. (#46061)

We need to make sure to add objects to the transfer list when we send them across the ui thread/web worker boundary. Otherwise, they get copied, which is very expensive.

On my M1 MacBook Pro, I took measurements of scrolling in the material 3 demo. Before this change, the work on the web worker thread was taking about 25-40ms per frame. After the change, it's around 2ms.

* [Impeller] adds hardware gate for wide gamut (#46051)

fixes https://github.com/flutter/flutter/issues/133015

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Roll Skia from fe3568162721 to 1a8885b9e03c (6 revisions) (#46075)

https://skia.googlesource.com/skia.git/+log/fe3568162721..1a8885b9e03c

2023-09-19 [email protected] Roll skottie-base from 6fbc053bdad0 to a5a762c16294
2023-09-19 [email protected] Roll debugger-app-base from 4880b92b4f1c to 927fde2f2c6e
2023-09-19 [email protected] Roll shaders-base from 75c3a7bb1f19 to b4ee53fe6042
2023-09-19 [email protected] Roll jsfiddle-base from 3c3b69cdbecd to 5a23365ca776
2023-09-19 [email protected] Fix a few more GCC warnings.
2023-09-19 [email protected] Revert "Enforce IWYU on more src/core files"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [Impeller] Fix validation errors in RendererTest. (#46076)

Vulkan validation was tripping on the fact that renderer tests were rendering to the root render pass. This root render pass doesn't contain a stencil buffer. However, `MakeDefaultPipelineDescriptor` assumes a stencil and color attachment. The other backends are resilient to this mismatch since there is no compat render pass created upfront. But Vulkan was sad. This should only happen in the low level tests. In the higher levels of the framework, we have variants that make sure there is a pipeline pass and render pass compatibility.

Fixes validations of the kind:

```
--- Vulkan Debug Report  ----------------------------------------
|                Severity: Error
|                    Type: { Validation }
|                 ID Name: VUID-vkCmdDraw-renderPass-02684
|               ID Number: 1349015333
|       Queue Breadcrumbs: [NONE]
|  CMD Buffer Breadcrumbs: [NONE]
|         Related Objects: RenderPass [16305153808034431137] [Playground Render Pass], RenderPass [18100546345029861533] [Compat Render Pass: BoxFade Pipeline]
|                 Trigger: Validation Error: [ VUID-vkCmdDraw-renderPass-02684 ] Object 0: handle = 0xe2478b00000000a1, name = Playground Render Pass, type = VK_OBJECT_TYPE_RENDER_PASS; Object 1: handle = 0xfb320f000000009d, name = Compat Render Pass: BoxFade Pipeline, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0x50685725 | vkCmdDraw: RenderPasses incompatible between active render pass w/ VkRenderPass 0xe2478b00000000a1[Playground Render Pass] and pipeline state object w/ VkRenderPass 0xfb320f000000009d[Compat Render Pass: BoxFade Pipeline] Attachment 4294967295 is not compatible with 1: The first is unused while the second is not.. The Vulkan spec states: The current render pass must be compatible with the renderPass member of the VkGraphicsPipelineCreateInfo structure specified when creating the VkPipeline bound to VK_PIPELINE_BIND_POINT_GRAPHICS (https://vulkan.lunarg.com/doc/view/1.3.224.1/mac/1.3-extensions/vkspec.html#VUID-vkCmdDraw-renderPass-02684)
-----------------------------------------------------------------

```

* [Impeller] Affinity adjustments for Vulkan backend. (#46063)

Runs the waiter threads with efficiency affinity and the worker thread with "not performance" affinity.

* [Impeller] Fix validation error about incorrect aspect on buffer to texture copies. (#46078)

This shows up when we try to set the contents of a depth of stencil image. The aspect was assumed to be color only because typical Impeller workloads have device-transient depth and stencil images. But the "stencil mask" test apparently does set the context directly. Besides, this is perfectly valid usage. This makes Vulkan resilient to said usage.

* Use magic envs to pass commit and temp folder. (#46015)

The fuchsia scripts rely on paths and the commit version being passed as parameters. This changes pass those values using special environment variables.

Bug: https://github.com/flutter/flutter/issues/126461

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Roll Fuchsia Mac SDK from 06g6i7-5u8O-FOTSi... to kGkqpvcPI1TGmR4Sc... (#46079)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 1a8885b9e03c to 5d916c04e9fc (6 revisions) (#46081)

https://skia.googlesource.com/skia.git/+log/1a8885b9e03c..5d916c04e9fc

2023-09-20 [email protected] Roll shaders-base from b4ee53fe6042 to ca3aa4986e49
2023-09-20 [email protected] Roll debugger-app-base from 927fde2f2c6e to 34426197856b
2023-09-20 [email protected] Roll jsfiddle-base from 5a23365ca776 to bc9bc348e2da
2023-09-20 [email protected] Roll skottie-base from a5a762c16294 to 4983a463d62a
2023-09-20 [email protected] [mesh2d demo] Include CK copy
2023-09-19 [email protected] [graphite][mtl] Align dynamic thread group memory to 16 bytes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Fuchsia Linux SDK from ZhY53WD7bFJSA3xoO... to aHtib4LBcLwx7JwK-... (#46082)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 5d916c04e9fc to d6325ec2f053 (1 revision) (#46083)

https://skia.googlesource.com/skia.git/+log/5d916c04e9fc..d6325ec2f053

2023-09-20 [email protected] Roll SK Tool from 1b17251d0e2c to 918412e0912f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [Impeller] Use BlackTransparent clear color when backdrop filters are present. (#46085)

Fix for https://github.com/flutter/flutter/issues/135053.

We already duck out of the Entity absorbing part of the optimization,
but we also need to duck here when computing clear colors, otherwise we
end up double-applying the effect of clearing entities at the beginning
of a pass in some cases.

* Roll Skia from d6325ec2f053 to e9b9e9a4f541 (1 revision) (#46086)

https://skia.googlesource.com/skia.git/+log/d6325ec2f053..e9b9e9a4f541

2023-09-20 [email protected] Roll Dawn from 58dbcccc38b5 to bc9a66c04290 (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [Impeller] Ensure that reused textures are cleared before getting sampled by backdrop textures (#46084)

Fix for https://github.com/flutter/flutter/issues/135053.

I'm going to try and optimize out this case later, since Wondrous is
inadvertently paying for a backdrop filter that contributes nothing to
the final image.

* Roll Dart SDK from b8f006d88c07 to b3fd178ce59f (3 revisions) (#46087)

https://dart.googlesource.com/sdk.git/+log/b8f006d88c07..b3fd178ce59f

2023-09-20 [email protected] Version 3.2.0-183.0.dev
2023-09-20 [email protected] Version 3.2.0-182.0.dev
2023-09-19 [email protected] Version 3.2.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from e9b9e9a4f541 to e3aa86332255 (1 revision) (#46088)

https://skia.googlesource.com/skia.git/+log/e9b9e9a4f541..e3aa86332255

2023-09-20 [email protected] Roll Skia Infra from 1b17251d0e2c to 918412e0912f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from e3aa86332255 to 14e9b3c91c64 (1 revision) (#46089)

https://skia.googlesource.com/skia.git/+log/e3aa86332255..14e9b3c91c64

2023-09-20 [email protected] Roll vulkan-deps from e1a78e7e85a9 to b8fa58ef74a9 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 14e9b3c91c64 to 7d9d5ac84d8f (1 revision) (#46090)

https://skia.googlesource.com/skia.git/+log/14e9b3c91c64..7d9d5ac84d8f

2023-09-20 [email protected] Roll ANGLE from 7cb117e0b06c to e305459968f2 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 7d9d5ac84d8f to d7f2d1083979 (1 revision) (#46091)

https://skia.googlesource.com/skia.git/+log/7d9d5ac84d8f..d7f2d1083979

2023-09-20 [email protected] Fix default values for gain map metadata.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Dart SDK from b3fd178ce59f to ed05ca364d5e (1 revision) (#46092)

https://dart.googlesource.com/sdk.git/+log/b3fd178ce59f..ed05ca364d5e

2023-09-20 [email protected] Version 3.2.0-184.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Dart SDK from b3fd178ce59f to ed05ca364d5e (1 revision) (#46093)

https://dart.googlesource.com/sdk.git/+log/b3fd178ce59f..ed05ca364d5e

2023-09-20 [email protected] Version 3.2.0-184.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from d7f2d1083979 to fd317812bd27 (2 revisions) (#46094)

https://skia.googlesource.com/skia.git/+log/d7f2d1083979..fd317812bd27

2023-09-20 [email protected] Expose 5 more paragraph methods from Canvaskit for Flutter.
2023-09-20 [email protected] Roll jsfiddle-base from bc9bc348e2da to 5b50d4261358

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from fd317812bd27 to 56ce5bb201c6 (4 revisions) (#46096)

https://skia.googlesource.com/skia.git/+log/fd317812bd27..56ce5bb201c6

2023-09-20 [email protected] [Fontations] Test path equivalence for a set of test fonts and strings
2023-09-20 [email protected] Migrate NVIDIA test disables into SkSLTest.cpp.
2023-09-20 [email protected] [graphite] Adjust the working context inside working format color filter
2023-09-20 [email protected] [graphite] Add a PaintOption class to the precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 56ce5bb201c6 to f54c214a739b (4 revisions) (#46098)

https://skia.googlesource.com/skia.git/+log/56ce5bb201c6..f54c214a739b

2023-09-20 [email protected] [skif] Use optionals to track unbounded input/output bounds
2023-09-20 [email protected] [graphite] Use Compose helper to implement dithering
2023-09-20 [email protected] Revert "[Fontations] Test path equivalence for a set of test fonts and strings"
2023-09-20 [email protected] Manual roll Dawn from bc9a66c04290 to 881dc3bb55fd (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Fuchsia Mac SDK from kGkqpvcPI1TGmR4Sc... to zuOP7YCHHocXuZJcD... (#46097)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from f54c214a739b to 9bc5eeb93a1e (2 revisions) (#46099)

https://skia.googlesource.com/skia.git/+log/f54c214a739b..9bc5eeb93a1e

2023-09-20 [email protected] Migrate Apple test disables into SkSLTest.cpp.
2023-09-20 [email protected] Migrate Intel test disables into SkSLTest.cpp.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [ios] Reland "[ios] use python script to generate extension safe frameworks and code sign them" #46004" (#46014)

Relands https://github.com/flutter/engine/pull/45781
The Flutter.framework and the sim folders are mistakenly added to the artifact, this PR removed those files along with re-landing the original changes 

https://github.com/flutter/flutter/pull/134966 should pass with this change. 

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Roll Skia from 9bc5eeb93a1e to 565d95f72f2e (1 revision) (#46100)

https://skia.googlesource.com/skia.git/+log/9bc5eeb93a1e..565d95f72f2e

2023-09-20 [email protected] Migrate remaining test disables into SkSLTest.cpp.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Fuchsia Linux SDK from aHtib4LBcLwx7JwK-... to QcxgV9KlY7j3o3b4j... (#46102)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Dart SDK from ed05ca364d5e to d5d05146868a (1 revision) (#46104)

https://dart.googlesource.com/sdk.git/+log/ed05ca364d5e..d5d05146868a

2023-09-20 [email protected] Version 3.2.0-185.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 565d95f72f2e to f4238844089f (3 revisions) (#46105)

https://skia.googlesource.com/skia.git/+log/565d95f72f2e..f4238844089f

2023-09-20 [email protected] Fix capitalization of ANGLE.
2023-09-20 [email protected] Add GM to test working-color-space color filter
2023-09-20 [email protected] Remove IncompleteShortIntPrecision workaround flag.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [web] Make `PlatformViewManager` a clear singleton (#46044)

Make it clear that `PlatformViewManager` is a singleton and follow the patterns that we use for other singleton classes.

Part of https://github.com/flutter/flutter/issues/134443

* Delete `ci/lint.sh`, which is no longer used. (#46049)

Found out while working on
https://github.com/flutter/flutter/issues/134969.

I suspect this stopped being used when we sharded out the Clang Tidy
builders?

* [web] Move context menu handling to its own class (#46042)

Remove all `contextmenu` responsibilities out of `FlutterViewEmbedder`/`EmbeddingStrategy`, and into its own `ContextMenu` class that's instantiated and managed by the view.

There's one major difference that this PR brings: the `contextmenu` event listener is now attached to the `<flutter-view>` element instead of `window`. Since the entire app is contained within `<flutter-view>`, I expect no issues with this change.

Part of https://github.com/flutter/flutter/issues/134443

* Roll Skia from f4238844089f to c19115e8f712 (5 revisions) (#46108)

https://skia.googlesource.com/skia.git/+log/f4238844089f..c19115e8f712

2023-09-20 [email protected] Re-enable existing SkSL tests.
2023-09-20 [email protected] [infra] bump gsutil version to 5.25
2023-09-20 [email protected] [mesh2d demo] Fix CK init URL
2023-09-20 [email protected] [skshaper] Split off SkUnicode specific code
2023-09-20 [email protected] Remove dead code from SPIR-V code generator.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from c19115e8f712 to b3c1f49821d8 (3 revisions) (#46112)

https://skia.googlesource.com/skia.git/+log/c19115e8f712..b3c1f49821d8

2023-09-20 [email protected] Roll shaders-base from ca3aa4986e49 to 40f881ed7b8b
2023-09-20 [email protected] Roll debugger-app-base from 34426197856b to 4bd4f2832866
2023-09-20 [email protected] Roll skottie-base from 4983a463d62a to a8dcc44b5814

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Make a variety of low-impact Clang tidy fixes. (#46114)

Work towards https://github.com/flutter/flutter/issues/134969.

These are all self-contained, so I bundled them all together.

All fixes are generated by `clang-tidy --fix`, and manual search/replace if that wasn't sufficient.

* [ios] fix asset url not found when loading app extension (#46073)

In https://github.com/flutter/engine/commit/9446392af6a26a715c6db50a56b23d46c141d834, I refactored the assetsPath to use NSURL. It turns out that when the app bundle is not loaded (during launching app exgtension), the assetURL will return nil using the `URLForResource`, but the `pathForResource` successfully returns the raw path.

This PR reverts back to the raw path solution.

part of https://github.com/flutter/flutter/issues/124287

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Make a variety of low-impact Clang tidy fixes in Impeller. (#46116)

Work towards https://github.com/flutter/flutter/issues/134969.

These are all self-contained, so I bundled them all together.

All fixes are generated by `clang-tidy --fix`, and manual search/replace if that wasn't sufficient.

* Roll Skia from b3c1f49821d8 to d923bab3d5fa (2 revisions) (#46118)

https://skia.googlesource.com/skia.git/+log/b3c1f49821d8..d923bab3d5fa

2023-09-20 [email protected] Add pack/unpack intrinsics to WGSL code generator.
2023-09-20 [email protected] Roll vulkan-deps from b8fa58ef74a9 to 2aba50a6944f (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Migrate from `LOG_X` to `kLogX`. (#46107)

These should be entirely non-breaking, i.e. 1:1 and same backing `int`
value.

(See https://github.com/flutter/engine/pull/46052)

* Make `dl_(image|mask|path)_(filter|effect).h` tidy! (#46110)

Closes https://github.com/flutter/flutter/issues/135064.
Closes https://github.com/flutter/flutter/issues/135063.
Closes https://github.com/flutter/flutter/issues/135062.

I bundled a few of these together because they didn't have side-effects
across the repo (self-contained).

**NOTE**: All changes were auto-generated by `clang-tidy --fix`.

* Make `dl_color_(filter|source)` tidy. (#46111)

Closes https://github.com/flutter/flutter/issues/135060.
Closes https://github.com/flutter/flutter/issues/135061.

Bundled these two together as they are similar. Pretty boring `instance`
-> `kInstance`, and `explicit`/`std::move`.

* Roll Skia from d923bab3d5fa to b78c91996051 (4 revisions) (#46119)

https://skia.googlesource.com/skia.git/+log/d923bab3d5fa..b78c91996051

2023-09-20 [email protected] Revert "Revert "Make SKP deserialize null instead of PNG images by default.""
2023-09-20 [email protected] Remove PackUnorm2x16 from SkSL tests.
2023-09-20 [email protected] Tidy up public.bzl rules for iOS
2023-09-20 [email protected] Fix test disables for PowerVR Rogue GE8300.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from b78c91996051 to 86f48da2c812 (4 revisions) (#46121)

https://skia.googlesource.com/skia.git/+log/b78c91996051..86f48da2c812

2023-09-20 [email protected] Roll jsfiddle-base from 5b50d4261358 to f4090760c770
2023-09-20 [email protected] Roll shaders-base from 40f881ed7b8b to c6e5b668b1a4
2023-09-20 [email protected] Roll debugger-app-base from 4bd4f2832866 to b5dc6c526875
2023-09-20 [email protected] Roll skottie-base from a8dcc44b5814 to b4674d1b2f50

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Apply the right tag for linux fuchsia cipd packages. (#46123)

The cipd packages were all being uploaded and tagged with git:HEAD.

Bug: https://github.com/flutter/flutter/issues/126461

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Clang tidy-ify `DlColor` and friends. (#46122)

Closes https://github.com/flutter/flutter/issues/135057.

This is a fair bit more involved than previous changes, just due to the sheer number of implicit conversions.

Highlights:

- Made `public uint32_t argb` `private uint32_t argb_`, and added `argb()` instead.
- Added `ToSk(DlColor)` instead of using implicit conversions.

There were a bunch of places where I had to make a judgement call (particularly in tests) to keep the code a bit "messy", i.e. `DlColor(SK_RED)`, just to make the diff as small as possible and to prevent silly copy and paste bugs. I'd be open to filing a follow-up issue to reduce unnecessary wrapping.

* [Impeller] Apply the entity transformation when rendering FramebufferBlendContents (#46106)

Fixes https://github.com/flutter/flutter/issues/134930

* [Impeller] Remove removal of save layer from clip. (#46113)

Fixes https://github.com/flutter/flutter/issues/134705

The save layer is observable so it isn't safe to optimize out.

* [Impeller] removed global mutable variable for tessellation allocation function pointers (#46127)

issue: https://github.com/flutter/flutter/issues/125749

This removes a global mutable variable, instead giving each tesellator its own struct.  I suspect the root cause of the linked  issue is memory corruption but this is good cleanup anyways.  If for some reason libTess2 is mutating that global variable at cleanup, that could be the source of this problem and this would fix the issue.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Roll Skia from 86f48da2c812 to a7bcbb9a39f3 (1 revision) (#46128)

https://skia.googlesource.com/skia.git/+log/86f48da2c812..a7bcbb9a39f3

2023-09-21 [email protected] Revert "Tidy up public.bzl rules for iOS"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Tidy up `DlPaint` and friends. (#46120)

Closes https://github.com/flutter/flutter/issues/135058.

Work towards https://github.com/flutter/flutter/issues/134969.

All fixes are generated by `clang-tidy --fix`, and manual search/replace
if that wasn't sufficient.

* Roll Skia from a7bcbb9a39f3 to 81b9c7fd19b2 (1 revision) (#46129)

https://skia.googlesource.com/skia.git/+log/a7bcbb9a39f3..81b9c7fd19b2

2023-09-21 [email protected] Roll SK Tool from 918412e0912f to af63cb4763f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [Impeller] temp work around for cmd pool validation issues. (#46131)

I'm not able to reproduce most validation errors in the macrobenchmark app with this change. THe real fix seems to be to track this last cmd buffer but I'm struggling to find a way to do this.

* Roll Fuchsia Mac SDK from zuOP7YCHHocXuZJcD... to 3DKf4d8UFviYKRI28... (#46133)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 81b9c7fd19b2 to c20aeee90da9 (3 revisions) (#46134)

https://skia.googlesource.com/skia.git/+log/81b9c7fd19b2..c20aeee90da9

2023-09-21 [email protected] Roll Skia Infra from 918412e0912f to af63cb4763f0 (11 revisions)
2023-09-21 [email protected] Roll Dawn from 881dc3bb55fd to 2eae44a62806 (11 revisions)
2023-09-21 [email protected] Add new flags to sksl-minify usage string.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from c20aeee90da9 to 322abacca561 (1 revision) (#46137)

https://skia.googlesource.com/skia.git/+log/c20aeee90da9..322abacca561

2023-09-21 [email protected] Roll vulkan-deps from 2aba50a6944f to 79912a37e72c (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Dart SDK from d5d05146868a to eaeca487c944 (2 revisions) (#46138)

https://dart.googlesource.com/sdk.git/+log/d5d05146868a..eaeca487c944

2023-09-21 [email protected] Version 3.2.0-187.0.dev
2023-09-20 [email protected] Version 3.2.0-186.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Add package:tar to DEPS (#46140)

It was added to the Dart SDK DEPS file here: https://github.com/dart-lang/sdk/commit/04fe6d62fcfc227813aab2ea0bfb7816648c7cac

* Roll Skia from 322abacca561 to 0cf83a86c56d (1 revision) (#46143)

https://skia.googlesource.com/skia.git/+log/322abacca561..0cf83a86c56d

2023-09-21 [email protected] Manual roll Dawn from 2eae44a62806 to 39aef37759a4 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Fuchsia Mac SDK from 3DKf4d8UFviYKRI28... to PXDDhlPyd9sgrWWun... (#46148)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Remove linux fuchsia from recipes cq. (#46153)

With some recent changes led builds can only run if they use -real-build. The migration of fuchsia builds to use -real-build as involved as migrating it to engine v2 and we are implementing the second one.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* Move `git_repo_tools` and `process_fakes` outside of `clang_tidy`. (#46017)

Closes https://github.com/flutter/flutter/issues/134988.

* Revert "[web] fix clicks on merged semantic nodes (#43620)" (#46067)

This reverts commit 0c1de9b8afbabe3857a3b495cc9b0bcfdf1ac305.

The commit caused https://github.com/flutter/flutter/issues/134842. I'm going to try again, this time accounting for nested clickables/tappables.

* Reland: Enforce the rule of calling FlutterView.Render (#45300) (#45555)

This PR relands #45300 which was reverted in https://github.com/flutter/engine/pull/45525 due to hanging on a windows startup test. The culprit test still calls `FlutterView.render` in the illegal way, which is ignored, causing no frame being ever produced. This has been fixed in https://github.com/flutter/flutter/pull/134245. I've also searched through the framework repo for `render(` to ensure there are no other cases.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

* More Clang Tidy --fix[es] to header files (#46151)

More work towards https://github.com/flutter/flutter/issues/134969.

I decided not to touch the `LOG_X` variables since they are just used in macro expansion.

* [Impeller] Use final cmd buffer to present drawable. (#46023)

If we're not running with a transaction then we don't need to block on waitUntilScheduled on any platform. I think this should always work, as the problems we had before were due to always using drawable present. But this helper method schedules the drawable presentation after the cmd buffer is scheduled - which is what we're doing with waitUntilScheduled anyway - just non blocking from our perspective.

Fixes https://github.com/flutter/flutter/issues/131520

* Re-enable HardwareBuffer backed Platform Views on Android >= 29 (#46071)

* Roll Skia from 0cf83a86c56d to a0928a46b9c8 (19 revisions) (#46164)

https://skia.googlesource.com/skia.git/+log/0cf83a86c56d..a0928a46b9c8

2023-09-21 [email protected] Roll vulkan-deps from 79912a37e72c to b7c710e0c890 (5 revisions)
2023-09-21 [email protected] Fixing Flutter roll build
2023-09-21 [email protected] Remove extra semicolon after macro
2023-09-21 [email protected] Remove packDouble2x32 intrinsics from SkSL.
2023-09-21 [email protected] Add SkRuntimeEffectPriv::VarAsChild.
2023-09-21 [email protected] [graphite] Implement Image and Blend Shaders using the Blend helper
2023-09-21 [email protected] Split apart MeshSpec tests into separate DEF_TESTs.
2023-09-21 [email protected] [graphite] Return transparent black when evaluating null child shader
2023-09-21 [email protected] [graphite][compute] Coverage mask format based on storage binding support
2023-09-21 [email protected] Manual roll ANGLE from e305459968f2 to 8fcd4a50ab47 (9 revisions)
2023-09-21 [email protected] [skif] Combine isCropped() and modifiesPixelsBeyondImage()
2023-09-21 [email protected] [skshaper] Use locale for line breaking
2023-09-21 [email protected] Set of utilities for Unicode comparison: Skia changes
2023-09-21 [email protected] [graphite] Implement DstReads w/ Blend helper
2023-09-21 [email protected] Disable DeadReturnES3 test on Radeon due to crashing.
2023-09-21 [email protected] Roll skottie-base from b4674d1b2f50 to bbf6a30f67f4
2023-09-21 [email protected] Roll jsfiddle-base from f4090760c770 to 3605928905e4
2023-09-21 [email protected] Roll shaders-base from c6e5b668b1a4 to 84356d9e8452
2023-09-21 [email protected] Roll debugger-app-base from b5dc6c526875 to 72a86e8cc35e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from a0928a46b9c8 to 611f08987be3 (2 revisions) (#46165)

https://skia.googlesource.com/skia.git/+log/a0928a46b9c8..611f08987be3

2023-09-21 [email protected] Add working color space shader
2023-09-21 [email protected] Remove deprecated API use

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Revert #46131, don't store `vkImage`, reset `vkComandPool` synchronously (#46166)

Closes https://github.com/flutter/flutter/issues/135086.

Reverts https://github.com/flutter/engine/pull/46131.

This PR bundles together 3 changes that removes all validation errors on the `macrobenchmark` apps I could manually find:

1. Reverts https://github.com/flutter/engine/pull/46131, which did not fix the original issue.
2. Added `kResetOnBackgroundThread = false`, which drops performance benefits, but doesn't cause threading issues.
3. Stop tracking `image` for Swapchain presentation (was hitting Vulkan assertion errors about acquired images).

/cc @gaaclarke I'd love to talk about how we could run the macrobenchmarks app on CI, with validation errors, after landing.

* Roll Skia from 611f08987be3 to 5b2dae1a9b54 (2 revisions) (#46168)

https://skia.googlesource.com/skia.git/+log/611f08987be3..5b2dae1a9b54

2023-09-21 [email protected] [graphite] Hook up software path renderer.
2023-09-21 [email protected] Add missing const

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [Impeller] fail if software backend is chosen and Impeller is enabled on iOS (#46124)

Fixes https://github.com/flutter/flutter/issues/127408

This is also related to https://github.com/flutter/engine/pull/44346, which made it fatal to explicitly request both impeller and the software backend.

Before landing this, we need to update some google internal tests that end up in this state to explicitly request Skia (or to get into a mode where they can actually use metal).

* Roll Skia from 5b2dae1a9b54 to 86454ab4f3de (1 revision) (#46175)

https://skia.googlesource.com/skia.git/+log/5b2dae1a9b54..86454ab4f3de

2023-09-22 [email protected] Roll SK Tool from af63cb4763f0 to 8ddc74eefa73

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Dart SDK from eaeca487c944 to 5d33f4c85b82 (1 revision) (#46176)

https://dart.googlesource.com/sdk.git/+log/eaeca487c944..5d33f4c85b82

2023-09-22 [email protected] Version 3.2.0-188.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Fuchsia Mac SDK from PXDDhlPyd9sgrWWun... to ZyajVWocCHVIuJkzM... (#46179)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Dart SDK from 5d33f4c85b82 to 6bde93a6e56f (1 revision) (#46180)

https://dart.googlesource.com/sdk.git/+log/5d33f4c85b82..6bde93a6e56f

2023-09-22 [email protected] Version 3.2.0-189.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 86454ab4f3de to 97ec4dbabd05 (1 revision) (#46181)

https://skia.googlesource.com/skia.git/+log/86454ab4f3de..97ec4dbabd05

2023-09-22 [email protected] Roll Dawn from 39aef37759a4 to 28d5970cfe84 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* [iOS] Disable spelling corrections when auto correction is disabled (#46144)

## Description

This iOS PR disables spellchecking when auto correction is disabled.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/134881.

## Tests

Adds 1 test.

* Roll Skia from 97ec4dbabd05 to 3ae3bb0d40df (1 revision) (#46182)

https://skia.googlesource.com/skia.git/+log/97ec4dbabd05..3ae3bb0d40df

2023-09-22 [email protected] Roll Skia Infra from af63cb4763f0 to 8ddc74eefa73 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from 3ae3bb0d40df to a3480a62e438 (1 revision) (#46183)

https://skia.googlesource.com/skia.git/+log/3ae3bb0d40df..a3480a62e438

2023-09-22 [email protected] [Graphite] Fix typo in PathAtlasFlags

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Roll Skia from a3480a62e438 to 8d9e2cd32ec7 (1 revision) (#46184)

https://skia.googlesource.com/skia.git/+log/a3480a62e438..8d9e2cd32ec7

2023-09-22 [email protected] Roll ANGLE from 8fcd4a50ab47 to 26148a023702 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issu…
@chinmaygarde chinmaygarde deleted the imageaspect branch August 22, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

@bdero bdero Awaiting requested review from bdero

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

@chinmaygarde chinmaygarde

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chinmaygarde @matanlurey