[Impeller] dont cache failed render target allocations. #45895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2023
…ions) (#134876) Manual roll requested by [email protected] flutter/engine@326faf1...30b7e9d 2023-09-15 [email protected] Roll Skia from 7f88bda24f7f to 0057898979a1 (1 revision) (flutter/engine#45904) 2023-09-15 [email protected] [Impeller] Test `FenceWaiterVK` and fix termination bugs (flutter/engine#45870) 2023-09-15 [email protected] Roll Dart SDK from a5ee0055cf20 to e9452310189b (1 revision) (flutter/engine#45902) 2023-09-15 [email protected] Roll Skia from 4f26f22daa4b to 7f88bda24f7f (5 revisions) (flutter/engine#45901) 2023-09-15 [email protected] [Impeller] dont cache failed render target allocations. (flutter/engine#45895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…ions) (flutter#134876) Manual roll requested by [email protected] flutter/engine@326faf1...30b7e9d 2023-09-15 [email protected] Roll Skia from 7f88bda24f7f to 0057898979a1 (1 revision) (flutter/engine#45904) 2023-09-15 [email protected] [Impeller] Test `FenceWaiterVK` and fix termination bugs (flutter/engine#45870) 2023-09-15 [email protected] Roll Dart SDK from a5ee0055cf20 to e9452310189b (1 revision) (flutter/engine#45902) 2023-09-15 [email protected] Roll Skia from 4f26f22daa4b to 7f88bda24f7f (5 revisions) (flutter/engine#45901) 2023-09-15 [email protected] [Impeller] dont cache failed render target allocations. (flutter/engine#45895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Otherwise we'll null de-ref when trying to create a texture with the same descriptor later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we'll null de-ref when trying to create a texture with the same descriptor later on.