Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Adds playgrounds test to CI. #45857

Closed
wants to merge 1 commit into from

Conversation

gaaclarke
Copy link
Member

issue: flutter/flutter#133506

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke
Copy link
Member Author

According to local testing, it seems like this may be able to work once #45870 lands.

@gaaclarke gaaclarke force-pushed the playgrounds-run-tests branch from 59b72b7 to 16a2db3 Compare September 15, 2023 22:13
@chinmaygarde chinmaygarde changed the title [Impeller] adds playgrounds test to ci [Impeller] Adds playgrounds test to CI. Sep 19, 2023
@matanlurey
Copy link
Contributor

I believe I did this in #45918 :)

@matanlurey matanlurey closed this Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants