[Impeller] transform text path offsets so color sources match expected offsets for gradients. #45255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
matanlurey
approved these changes
Aug 30, 2023
impeller/geometry/path.cc
Outdated
| for (const auto& component : components_) { | ||
| switch (component.type) { | ||
| case ComponentType::kLinear: | ||
| linears_[component.index].p1 = linears_[component.index].p1 + shift; |
There was a problem hiding this comment.
I don't know C++.
That being said, can you write:
liners[component.index].p1 += shift...? or does that not work with vectors/arrays?
If not, at least pull index into auto const index = component.index :)
There was a problem hiding this comment.
Fun fact, += is a different operator than + (see point.h)
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2023
…ch expected offsets for gradients. (flutter/engine#45255)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2023
…133621) flutter/engine@749e67a...69f04bd 2023-08-30 [email protected] [Impeller] transform text path offsets so color sources match expected offsets for gradients. (flutter/engine#45255) 2023-08-30 [email protected] Roll Skia from e6eb56d9b074 to fde9fe141863 (1 revision) (flutter/engine#45260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…d offsets for gradients. (flutter#45255) Gradient offsets are computed based on path offsets + gradient positions, so we need to shift the points instead of just adding a concat to the canvas. Fixes flutter/flutter#132972 ### Skia  ### Impeller (No Patch)  ### Impeller (W/ Patch) 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradient offsets are computed based on path offsets + gradient positions, so we need to shift the points instead of just adding a concat to the canvas. Fixes flutter/flutter#132972
Skia
Impeller (No Patch)
Impeller (W/ Patch)