Reland: [Rasterizer] Make resubmit information temporary #45037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utter#42455)" This reverts commit 476d3c3.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Aug 24, 2023
dkwingsmt
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 25, 2023
…133296) flutter/engine@965501a...b8ec4da 2023-08-24 [email protected] Roll Skia from 99a76ea8e1b2 to 1428f16fc0de (1 revision) (flutter/engine#45086) 2023-08-24 [email protected] Roll Skia from 25fafff5b32c to 99a76ea8e1b2 (2 revisions) (flutter/engine#45083) 2023-08-24 [email protected] Revert "Turn on the `skia_enable_optimize_size` flag to save a bit of binary size" (flutter/engine#45082) 2023-08-24 [email protected] Roll Skia from d7d56885a49b to 25fafff5b32c (1 revision) (flutter/engine#45081) 2023-08-24 [email protected] [Impeller] Do not build scene unless 3d define is true (flutter/engine#45028) 2023-08-24 [email protected] Roll Skia from 177e8477faf9 to d7d56885a49b (1 revision) (flutter/engine#45078) 2023-08-24 [email protected] Reland: [Rasterizer] Make resubmit information temporary (flutter/engine#45037) 2023-08-24 [email protected] Add case checking to android sdk cipd upload script (flutter/engine#45063) 2023-08-24 [email protected] Roll Skia from 007386294889 to 177e8477faf9 (1 revision) (flutter/engine#45076) 2023-08-24 [email protected] Turn on the `skia_enable_optimize_size` flag to save a bit of binary size (flutter/engine#45029) 2023-08-24 [email protected] Roll Skia from b17ee34f3378 to 007386294889 (1 revision) (flutter/engine#45075) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Relands flutter#42001. The previous attempt was reverted due to post-submit flakeness, some mysterious crashes. I didn't change anything this time, but now that PR flutter#44973 is merged that fixes some racing issues, I wonder if the crashes of this change are resolved as well. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #42001.
The previous attempt was reverted due to post-submit flakeness, some mysterious crashes. I didn't change anything this time, but now that PR #44973 is merged that fixes some racing issues, I wonder if the crashes of this change are resolved as well.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.