Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arm64 machines for ios_debug_sim_arm64 test. #44920

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Use arm64 machines for ios_debug_sim_arm64 test. #44920

merged 1 commit into from
Aug 21, 2023

Conversation

godofredoc
Copy link
Contributor

The test is failing when running on a x64 machine and we are pinning this test to use arm64.

Bug: flutter/flutter#132993

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The test is failing when running on a x64 machine and we are pinning
this test to use arm64.

Bug: flutter/flutter#132993
@godofredoc godofredoc requested a review from zanderso August 21, 2023 20:57
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 21, 2023

auto label is removed for flutter/engine/44920, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2023
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2023
@auto-submit auto-submit bot merged commit 55b8426 into flutter:main Aug 21, 2023
@godofredoc godofredoc deleted the pin_arm64 branch August 21, 2023 22:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 21, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 21, 2023
…133000)

flutter/engine@e5f690b...55b8426

2023-08-21 [email protected] Use arm64 machines for ios_debug_sim_arm64 test. (flutter/engine#44920)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso added a commit to zanderso/engine that referenced this pull request Aug 25, 2023
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
The test is failing when running on a x64 machine and we are pinning this test to use arm64.

Bug: flutter/flutter#132993

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants