-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use arm64 machines for ios_debug_sim_arm64 test. #44920
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is failing when running on a x64 machine and we are pinning this test to use arm64. Bug: flutter/flutter#132993
zanderso
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
godofredoc
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Aug 21, 2023
auto label is removed for flutter/engine/44920, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Aug 21, 2023
godofredoc
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Aug 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 21, 2023
…133000) flutter/engine@e5f690b...55b8426 2023-08-21 [email protected] Use arm64 machines for ios_debug_sim_arm64 test. (flutter/engine#44920) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Aug 25, 2023
…)" This reverts commit 55b8426.
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
The test is failing when running on a x64 machine and we are pinning this test to use arm64. Bug: flutter/flutter#132993 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is failing when running on a x64 machine and we are pinning this test to use arm64.
Bug: flutter/flutter#132993
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.