-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] Build Impeller Vulkan backend on Windows #40196
Conversation
37abda6
to
1d56932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
I'm doing the same since I could use better GPU debugging tools available on Windows. We can land this but I'll have some trouble merging this stuff into my branch as I've significantly reworked capability checks. Just a heads up that this will change soon :) LGTM. |
Alrighty, I got rid of the added |
Fix build errors for Vulkan in Windows.
I spent some time trying to figure out why
vmaCreateImage
is failing withErrorFeatureNotPresent
, but didn't manage to figure it out.