Remove references to Observatory #38919

bkonyi · 2023-01-16T17:18:32Z

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags.

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See dart-lang/sdk#50233

bkonyi · 2023-01-17T16:26:53Z

shell/platform/darwin/ios/framework/Source/FlutterDartVMServicePublisher.mm

@@ -83,18 +83,18 @@ - (void)publishServiceProtocolPort:(NSURL*)url {
  // Physical devices need to request all interfaces.
  uint32_t interfaceIndex = 0;
 #endif  // TARGET_IPHONE_SIMULATOR
-  const char* registrationType = "_dartobservatory._tcp";
+  const char* registrationType = "_dartVmService._tcp";


@jmagman I'd like to change the mDNS entry name to stop referencing Observatory. Are there any gotchas I should be aware of? Should we be supporting both _dartVmService._tcp and _dartobservatory._tcp until flutter_tools is updated?

Yes, you'll need to support both until the tool is updated or the engine->flutter roll will have a wall of test failures. I don't see any usages in g3 and I can't think of gotchas outside of the tool (please add me as a reviewer when you get to that PR).

cc @vashworth who is working on that area of the tool at the moment flutter/flutter#118104

Makes sense. I have a WIP PR ready for updating the tool here: flutter/flutter#118577, so I'll add you to that PR once this change lands and I've confirmed things are working as expected.

shell/platform/embedder/tests/embedder_config_builder.cc

…18793)

…8919) (#118793) Commit: 46c7fd14da027f71e2c300e392bd1976b56d30a4

) (flutter/flutter#118793)

bparrishMines · 2023-01-20T03:46:56Z

shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java

   *
   * <p>Its value is set by the native engine once {@link #init(Context, String[], String, String,
   * String, long)} is run.
   */
  @Nullable
-  public static String getObservatoryUri() {
-    return observatoryUri;
+  public static String getVMServiceUri() {


@bkonyi The removal of this is breaking the espresso plugin: https://github.com/flutter/plugins/blob/main/packages/espresso/android/src/main/java/androidx/test/espresso/flutter/action/FlutterViewAction.java#L108

And is breaking the Flutter to plugins roller.

Could we add the getObservatoryUri back and mark it as deprecated until getVMServiceUri makes it to stable?

@bparrishMines if this issue is blocking rolls, please file a P0 on GitHub, and assign @bkonyi.

Created flutter/flutter#118896

@pragma

* da5f8cf Roll Flutter Engine from a512cebdcd30 to 7dc5e7efa66a (2 revisions) (flutter/flutter#118505) * baefecc 35479aa1c Roll Fuchsia Mac SDK from 21nYb648VWbpxc36t... to w0hr1ZMvYGJnWInwK... (flutter/engine#38880) (flutter/flutter#118509) * ca300ce 25cb82272 Add include to make g3 happy (flutter/engine#38850) (flutter/flutter#118510) * 1220245 f79030440 Roll Skia from c72c7bf7e45b to c64a10d525d1 (7 revisions) (flutter/engine#38858) (flutter/flutter#118511) * 7188c3e Update documentation about accent color (flutter/flutter#116778) * 8c2fdb8 M3 Button padding adjustments (flutter/flutter#118449) * f22280a Revert "M3 Button padding adjustments (#118449)" (flutter/flutter#118598) * cc7845e Post a ToolEvent when selecting widget for inspection (flutter/flutter#118098) * a3629a2 Roll Plugins from 92a5367 to 4e5cf2d (8 revisions) (flutter/flutter#118624) * ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d55 Devicelab android emulator (flutter/flutter#113472) * 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576) * 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640) * 3348987 Add new macos target configured for flavors (flutter/flutter#117352) * 6277520 Roll Plugins from 4e5cf2d to 11361d0 (4 revisions) (flutter/flutter#118682) * 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a Fix path for require.js (flutter/flutter#118722) * c83a698 update uikit view documentation (flutter/flutter#118715) * 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e Docs fix an=>a (flutter/flutter#118652) * 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681) * 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104) * cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421)

) (flutter/flutter#118793)

Reason for revert: breaking Flutter -> plugins roll This reverts commit 88e61d8.

) (flutter/flutter#118793)

Reason for revert: breaking Flutter -> plugins roll This reverts commit 88e61d8.

) (flutter/flutter#118793)

@pragma

* 3348987 Add new macos target configured for flavors (flutter/flutter#117352) * 6277520 Roll Plugins from 4e5cf2d to 11361d0 (4 revisions) (flutter/flutter#118682) * 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a Fix path for require.js (flutter/flutter#118722) * c83a698 update uikit view documentation (flutter/flutter#118715) * 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e Docs fix an=>a (flutter/flutter#118652) * 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681) * 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104) * cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421) * 030288d Revert "[macos] add flavor options to commands in the `flutter_tool` (#118421)" (flutter/flutter#118858) * 9acf34d Roll Flutter Engine from 26b6609c603b to 7d40e77d0035 (2 revisions) (flutter/flutter#118852) * ec51d32 Remove unnecessary null checks in ‘dev/conductor’ (flutter/flutter#118843) * 54217bd Remove unnecessary null checks in `dev/benchmarks` (flutter/flutter#118840) * 98c18ca Remove unnecessary null checks in examples/ (flutter/flutter#118848) * 99b5262 Remove unnecessary null checks in dev/tools (flutter/flutter#118845) * 52d1205 Roll Flutter Engine from 7d40e77d0035 to 730e88fb6787 (3 revisions) (flutter/flutter#118869) * ee9c9b6 3876320cb Roll Skia from aedfc8695954 to 1b3aa8b6e1cc (43 revisions) (flutter/engine#39024) (flutter/flutter#118871) * 589f2eb d2436a536 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39020) (flutter/flutter#118873) * 74645b4 Fix `NavigationBar` indicator ripple doesn't account for label height (flutter/flutter#117473) * f78b1f3 dfe67f4c7 Roll Skia from 1b3aa8b6e1cc to f6a5c806294d (11 revisions) (flutter/engine#39027) (flutter/flutter#118874) * 572f0a1 66e177a3d Roll Dart SDK from ddf70a598f27 to fbbfc122dba6 (9 revisions) (flutter/engine#39029) (flutter/flutter#118878) * 26472b5 ccccee513 [macos] Synthesize modifier keys events on pointer events (flutter/engine#37870) (flutter/flutter#118880) * 095b1ab Checkbox borderSide lerp bug fix (flutter/flutter#118728) * ec6ff90 Roll Flutter Engine from ccccee513fb2 to d84b3dc74c9f (2 revisions) (flutter/flutter#118893) * 492d572 Cleanup obsolete --compact-async compiler option (flutter/flutter#118894) * f291eb3 Remove unnecessary null checks in integration_test (flutter/flutter#118861) * ab3c822 Remove unnecessary null checks in dev/devicelab (flutter/flutter#118842) * bf72f5e 58eb1061e Revert "Remove references to Observatory (#38919)" (flutter/engine#39035) (flutter/flutter#118899) * a07e8a6 [reland] Support wireless debugging (flutter/flutter#118895)

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See dart-lang/sdk#50233

) Reason for revert: breaking Flutter -> plugins roll This reverts commit 88e61d8.

This reverts commit 5dd9454.

@pragma

* 3348987 Add new macos target configured for flavors (flutter/flutter#117352) * 6277520 Roll Plugins from 4e5cf2d to 11361d0 (4 revisions) (flutter/flutter#118682) * 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a Fix path for require.js (flutter/flutter#118722) * c83a698 update uikit view documentation (flutter/flutter#118715) * 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e Docs fix an=>a (flutter/flutter#118652) * 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681) * 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104) * cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421) * 030288d Revert "[macos] add flavor options to commands in the `flutter_tool` (#118421)" (flutter/flutter#118858) * 9acf34d Roll Flutter Engine from 26b6609c603b to 7d40e77d0035 (2 revisions) (flutter/flutter#118852) * ec51d32 Remove unnecessary null checks in ‘dev/conductor’ (flutter/flutter#118843) * 54217bd Remove unnecessary null checks in `dev/benchmarks` (flutter/flutter#118840) * 98c18ca Remove unnecessary null checks in examples/ (flutter/flutter#118848) * 99b5262 Remove unnecessary null checks in dev/tools (flutter/flutter#118845) * 52d1205 Roll Flutter Engine from 7d40e77d0035 to 730e88fb6787 (3 revisions) (flutter/flutter#118869) * ee9c9b6 3876320cb Roll Skia from aedfc8695954 to 1b3aa8b6e1cc (43 revisions) (flutter/engine#39024) (flutter/flutter#118871) * 589f2eb d2436a536 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39020) (flutter/flutter#118873) * 74645b4 Fix `NavigationBar` indicator ripple doesn't account for label height (flutter/flutter#117473) * f78b1f3 dfe67f4c7 Roll Skia from 1b3aa8b6e1cc to f6a5c806294d (11 revisions) (flutter/engine#39027) (flutter/flutter#118874) * 572f0a1 66e177a3d Roll Dart SDK from ddf70a598f27 to fbbfc122dba6 (9 revisions) (flutter/engine#39029) (flutter/flutter#118878) * 26472b5 ccccee513 [macos] Synthesize modifier keys events on pointer events (flutter/engine#37870) (flutter/flutter#118880) * 095b1ab Checkbox borderSide lerp bug fix (flutter/flutter#118728) * ec6ff90 Roll Flutter Engine from ccccee513fb2 to d84b3dc74c9f (2 revisions) (flutter/flutter#118893) * 492d572 Cleanup obsolete --compact-async compiler option (flutter/flutter#118894) * f291eb3 Remove unnecessary null checks in integration_test (flutter/flutter#118861) * ab3c822 Remove unnecessary null checks in dev/devicelab (flutter/flutter#118842) * bf72f5e 58eb1061e Revert "Remove references to Observatory (#38919)" (flutter/engine#39035) (flutter/flutter#118899) * a07e8a6 [reland] Support wireless debugging (flutter/flutter#118895)

This reverts commit 5dd9454.

@pragma

* da5f8cf Roll Flutter Engine from a512cebdcd30 to 7dc5e7efa66a (2 revisions) (flutter/flutter#118505) * baefecc 35479aa1c Roll Fuchsia Mac SDK from 21nYb648VWbpxc36t... to w0hr1ZMvYGJnWInwK... (flutter/engine#38880) (flutter/flutter#118509) * ca300ce 25cb82272 Add include to make g3 happy (flutter/engine#38850) (flutter/flutter#118510) * 1220245 f79030440 Roll Skia from c72c7bf7e45b to c64a10d525d1 (7 revisions) (flutter/engine#38858) (flutter/flutter#118511) * 7188c3e Update documentation about accent color (flutter/flutter#116778) * 8c2fdb8 M3 Button padding adjustments (flutter/flutter#118449) * f22280a Revert "M3 Button padding adjustments (#118449)" (flutter/flutter#118598) * cc7845e Post a ToolEvent when selecting widget for inspection (flutter/flutter#118098) * a3629a2 Roll Plugins from 92a5367 to 4e5cf2d (8 revisions) (flutter/flutter#118624) * ae7b99e Rename `_*Marker` classes to be `_*Scope`, for consistency (flutter/flutter#118070) * 6fafbc3 Updated tokens to v0.152 (flutter/flutter#118594) * 4b3cf9b Add reference to HardwareKeyboard in RawKeyboard documentation (flutter/flutter#118607) * 0449030 Disable Xcode cache cleanup (flutter/flutter#118641) * f989d55 Devicelab android emulator (flutter/flutter#113472) * 0eaa83a Fix some Focus related documentation typos (flutter/flutter#118576) * 780563c Add const constructor to TextInputFormatter (flutter/flutter#116654) * 973cff4 [Re-land] Button padding m3 (flutter/flutter#118640) * 3348987 Add new macos target configured for flavors (flutter/flutter#117352) * 6277520 Roll Plugins from 4e5cf2d to 11361d0 (4 revisions) (flutter/flutter#118682) * 997d436 Fix applyBoxFit's handling of fitWidth and fitHeight. (flutter/flutter#117185) * 8a58ec5 Roll Flutter Engine from f79030440948 to c52b290813bd (29 revisions) (flutter/flutter#118720) * 374f09e [flutter_tools] No more implicit --no-sound-null-safety (flutter/flutter#118491) * ae1cc18 remove single-view assumption from `paintImage` (flutter/flutter#118721) * bb8b96a Fix path for require.js (flutter/flutter#118722) * c83a698 update uikit view documentation (flutter/flutter#118715) * 2b3ca0d Bump github/codeql-action from 2.1.38 to 2.1.39 (flutter/flutter#118735) * 666dccc [macOS] bringup new e2e_summary devicelab test (flutter/flutter#118717) * d07b88e Docs fix an=>a (flutter/flutter#118652) * 11d21e0 Add @pragma('vm:entry-point') to RestorableRouteBuilder arguments (flutter/flutter#118738) * 7d9eaab Appbar iconTheme override fix (flutter/flutter#118681) * 6f70830 Roll Flutter Engine from c52b290813bd to 290636c1cb6b (2 revisions) (flutter/flutter#118743) * b3059d2 Bump activesupport from 6.1.5 to 6.1.7.1 in /dev/ci/mac (flutter/flutter#118745) * ffcf63a Add verbose flag to plugin_dependencies_test to debug flake (flutter/flutter#118755) * 2609212 2a11023c7 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) (flutter/flutter#118751) * 21fb443 8ed6790b5 Bump chrome_and_driver version to 110. (flutter/engine#38986) (flutter/flutter#118758) * e5c9d06 Forgot to remove emulator flag. (flutter/flutter#118762) * 6a9b2db 95b0c151f Roll Dart SDK from 645fd748e79e to ddf70a598f27 (14 revisions) (flutter/engine#38990) (flutter/flutter#118763) * 0bbb5ec 40f7f0f09 Roll Fuchsia Mac SDK from P5QcCJU8I71xVXuMT... to tlYMsnCv86Fjt5LfF... (flutter/engine#38994) (flutter/flutter#118771) * d53cc4a [macOS] New e2e_summary benchmark fails without Cocoapods. (flutter/flutter#118754) * 3e71e0c Updated `ListTile` documentation, add Material 3 example and other `ListTile` examples fixes. (flutter/flutter#118705) * 213b3cb Check whether slider is mounted before interaction, no-op if unmounted (flutter/flutter#113556) * 06909cc Update packages + fix tests for javascript mime change (flutter/flutter#118617) * 46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919) (flutter/flutter#118793) * b9ab640 Remove incorrect statement in documentation (flutter/flutter#118636) * ea36b3a Add focus detector to CupertinoSwitch (flutter/flutter#118345) * 9b5ea30 Switching over from iOS-15 to iOS-16 in .ci.yaml. (flutter/flutter#118807) * 67ffaef 29a0582a1 Roll Fuchsia Mac SDK from tlYMsnCv86Fjt5LfF... to 6oiZwMyNsjucSxTHJ... (flutter/engine#39004) (flutter/flutter#118817) * 5cd2d4c Support iOS wireless debugging (flutter/flutter#118104) * cbf2e16 Revert "Support iOS wireless debugging (#118104)" (flutter/flutter#118826) * 2258590 Do not run Mac_arm64_ios run_debug_test_macos in presubmit during iPhone 11 migration (flutter/flutter#118828) * 1dd7f45 Add `build macos --config-only` option. (flutter/flutter#118649) * 22520f5 [macOS] Add timeline summary benchmarks (flutter/flutter#118748) * 99e4ca5 Roll Flutter Engine from 29a0582a1d5f to 78bbea005d27 (2 revisions) (flutter/flutter#118829) * c5ceff1 [flutter_tools] Ensure service worker starts caching assets since first load (flutter/flutter#116833) * 818bb4e Roll Flutter Engine from 78bbea005d27 to 26b6609c603b (3 revisions) (flutter/flutter#118839) * 09bd0f6 Support logging 'flutter run' communication to DAP clients (flutter/flutter#118674) * 73096fd [macos] add flavor options to commands in the `flutter_tool` (flutter/flutter#118421)

Remove references to Observatory

2c12106

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See dart-lang/sdk#50233

flutter-dashboard bot added embedder Related to the embedder API platform-android platform-fuchsia platform-ios platform-web Code specifically for the web engine labels Jan 16, 2023

bkonyi added 5 commits January 16, 2023 16:21

Support legacy flags

550aa4a

Fix build

cfd4908

Fix build

1c15d6e

Fix build

b7af51c

Fix lint

0d6aa5e

bkonyi commented Jan 17, 2023

View reviewed changes

Update licenses

692abb9

bkonyi changed the title ~~[WIP] Remove references to Observatory~~ Remove references to Observatory Jan 17, 2023

bkonyi requested review from zanderso, jmagman and chinmaygarde January 17, 2023 16:51

jmagman reviewed Jan 17, 2023

View reviewed changes

shell/platform/embedder/tests/embedder_config_builder.cc Show resolved Hide resolved

Support legacy mDNS registration type

f52884c

jmagman approved these changes Jan 18, 2023

View reviewed changes

bkonyi merged commit 88e61d8 into main Jan 19, 2023

bkonyi deleted the remove_observatory_references branch January 19, 2023 14:20

engine-flutter-autoroll mentioned this pull request Jan 19, 2023

Roll Flutter Engine from 40f7f0f09976 to 88e61d8bd166 (1 revision) flutter/flutter#118793

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 19, 2023

88e61d8bd Remove references to Observatory (flutter/engine#38919)

d08c03a

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 19, 2023

88e61d8bd Remove references to Observatory (flutter/engine#38919) (#1…

46c7fd1

…18793)

sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Jan 19, 2023

flutter: 88e61d8bd Remove references to Observatory (flutter/engine#3…

994d645

…8919) (#118793) Commit: 46c7fd14da027f71e2c300e392bd1976b56d30a4

This was referenced Jan 19, 2023

Roll Flutter from 68dd63d66ba6 to 46c7fd14da02 (43 revisions) flutter/packages#3069

Closed

Roll Flutter from 973cff40b402 to 46c7fd14da02 (26 revisions) flutter/plugins#6992

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 19, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

62d98a7

) (flutter/flutter#118793)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

985356d

) (flutter/flutter#118793)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 20, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

f863e66

) (flutter/flutter#118793)

bparrishMines reviewed Jan 20, 2023

View reviewed changes

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to 095b1abdad6f (54 revisions) flutter/plugins#6997

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

f52569c

) (flutter/flutter#118793)

bkonyi added a commit that referenced this pull request Jan 20, 2023

Revert "Remove references to Observatory (#38919)"

5dd9454

Reason for revert: breaking Flutter -> plugins roll This reverts commit 88e61d8.

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to 095b1abdad6f (54 revisions) flutter/plugins#6998

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

582d576

) (flutter/flutter#118793)

bkonyi added a commit that referenced this pull request Jan 20, 2023

Revert "Remove references to Observatory (#38919)" (#39035)

58eb106

Reason for revert: breaking Flutter -> plugins roll This reverts commit 88e61d8.

bparrishMines mentioned this pull request Jan 20, 2023

Flutter to Plugin Roll broken by removal of FlutterJNI. getObservatoryUri flutter/flutter#118896

Closed

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to ec6ff90ab0e6 (55 revisions) flutter/plugins#6999

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

92eaa98

) (flutter/flutter#118793)

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to 492d57262faf (56 revisions) flutter/plugins#7000

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

ecd1cba

) (flutter/flutter#118793)

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to f291eb3495f2 (57 revisions) flutter/plugins#7001

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

1904f4d

) (flutter/flutter#118793)

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to ab3c82244e27 (58 revisions) flutter/plugins#7002

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

8463179

) (flutter/flutter#118793)

engine-flutter-autoroll mentioned this pull request Jan 20, 2023

Roll Flutter from 973cff40b402 to a07e8a6ac43d (60 revisions) flutter/plugins#7003

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 20, 2023

46c7fd1 88e61d8bd Remove references to Observatory (flutter/engine#38919

5f4d8b5

) (flutter/flutter#118793)

ricardoamador pushed a commit to ricardoamador/engine that referenced this pull request Jan 25, 2023

Remove references to Observatory (flutter#38919)

9234df1

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See dart-lang/sdk#50233

ricardoamador pushed a commit to ricardoamador/engine that referenced this pull request Jan 25, 2023

Revert "Remove references to Observatory (flutter#38919)" (flutter#39035

748397f

) Reason for revert: breaking Flutter -> plugins roll This reverts commit 88e61d8.

bkonyi added a commit that referenced this pull request Jan 25, 2023

Reland "Remove references to Observatory (#38919)"

da2c3cd

This reverts commit 5dd9454.

bkonyi added a commit that referenced this pull request Jan 30, 2023

Reland "Remove references to Observatory (#38919)" (#39139)

396c7fd

This reverts commit 5dd9454.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove references to Observatory #38919

Remove references to Observatory #38919

bkonyi commented Jan 16, 2023

bkonyi Jan 17, 2023

jmagman Jan 17, 2023

bkonyi Jan 17, 2023

bparrishMines Jan 20, 2023

zanderso Jan 20, 2023

bparrishMines Jan 20, 2023

Remove references to Observatory #38919

Remove references to Observatory #38919

Conversation

bkonyi commented Jan 16, 2023

bkonyi Jan 17, 2023

Choose a reason for hiding this comment

jmagman Jan 17, 2023

Choose a reason for hiding this comment

bkonyi Jan 17, 2023

Choose a reason for hiding this comment

bparrishMines Jan 20, 2023

Choose a reason for hiding this comment

zanderso Jan 20, 2023

Choose a reason for hiding this comment

bparrishMines Jan 20, 2023

Choose a reason for hiding this comment