Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont snap in preroll #36239

Merged
merged 1 commit into from
Sep 19, 2022
Merged

dont snap in preroll #36239

merged 1 commit into from
Sep 19, 2022

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Sep 18, 2022 •
edited
Loading

Went back to https://github.com/flutter/engine/blob/flutter-1.25-candidate.6/flow/layers/opacity_layer.cc

and this seems more consistent. Any issues this fixed will need to be fixed differently

@jonahwilliams jonahwilliams marked this pull request as ready for review September 19, 2022 16:06
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@auto-submit auto-submit bot merged commit a7efead into flutter:main Sep 19, 2022
@jonahwilliams jonahwilliams deleted the nvm branch September 19, 2022 20:16
jonahwilliams added a commit to jonahwilliams/engine that referenced this pull request Sep 19, 2022
@jonahwilliams
dont snap in preroll (flutter#36239)
ab90fcb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 19, 2022
@engine-flutter-autoroll
a7efeada6 dont snap in preroll (flutter/engine#36239)
cdd86f2
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@jonahwilliams @OlehSv
dont snap in preroll (flutter#36239)
178b4d4
itsjustkevin pushed a commit that referenced this pull request Sep 29, 2022
@jonahwilliams
Dont snap in pre-roll (#36173) (#36181)
f23af29 
* Ensure pre-rolled opacity children see snapped matrix (#36173)

* Fix preroll matrix snapping (#36213)

* ++

* dont snap in preroll (#36239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahwilliams @dnfield