[web] Migrate Flutter Web to JS static interop - 9. #32564
Conversation
|
@srujzs ptal |
|
LGTM |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
joshualitt
requested review from
eyebrowsoffire
and removed request for
yjbanov
| } | ||
|
|
||
| extension SkFontExtension on SkFont { | ||
| external Uint16List getGlyphIDs(String text); |
There was a problem hiding this comment.
Huh, I guess we had this typed incorrectly all along? Uint16List seems correct looking at the canvaskit bindings.
|
Is the Uint8List/Uint16List issue purely a type correctness thing or would it actually manifest as a bug in practice? |
|
test-exempt: the answer is apparently "purely type correctness", so, code refactor with no semantic change. |
This is CL 9 in a series of CLs to migrate Flutter Web to the new JS static interop API.
This CL migrates SkFont on its own because it needed a change to a type signature.