Detach from GL context before attaching #31390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2022 19:56
shell/platform/android/io/flutter/embedding/engine/renderer/SurfaceTextureWrapper.java
Outdated
Show resolved
Hide resolved
jason-simmons
approved these changes
Feb 11, 2022
shell/platform/android/io/flutter/embedding/engine/renderer/SurfaceTextureWrapper.java
Outdated
Show resolved
Hide resolved
blasten
force-pushed
the
fix_tx_attachToGLContext
branch
from
48f4b86 to
b797079
Compare
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Feb 17, 2022
itsjustkevin
added a commit
that referenced
this pull request
Feb 18, 2022
* Fix crash in BackdropFilterLayer::Diff (#30460) * Fix crash in BackdropFilterLayer::Diff * Pass context transform to filterBounds instead of scaling the filter * Disable building examples by default (#30946) This should be paired with a recipe change to enable building the example on CI that I'll prepare shortly. * Detach from GL context before attaching (#31390) * 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml' * remove ref to branch * add junit dependency to gradle.build Co-authored-by: Matej Knopp <[email protected]> Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]> Co-authored-by: Kevin Chisholm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the rasterizer tasks run on a different thread, the GrContext is re-created.
This causes the texture to be in an uninitialized state.
This should not be an issue once platform views are always rendered as TextureLayers
since thread merging will be always disabled on Android.
Fixes flutter/flutter#98155