This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[fuchsia] Update Vulkan header version to 1.2.198. #30770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
reviewed
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but a few things to do before landing
- Update licenses_third_party to fix the check
- Wait for a successful Fuchsia SDK roll
- Verify this works on smart_display -- does smart_display use a Fuchsia image / vulkan ICD that is compatible with the new headers?
arbreng
approved these changes
Jan 10, 2022
akbiggs
approved these changes
Jan 11, 2022
The licenses need to be updated. The diff is at the bottom of the logs here. You should just be able to apply the patch yourself instead of having to run the script again. |
4319e14
to
bdd973c
Compare
All done. Fuchsia image / SDK in g3 has been updated so that they are already using the ICD and loader compatible with the new headers. |
This updates the downstream Vulkan header for Fuchsia to 1.2.198 so that it could support the upstream FUCHSIA buffer collection extension. TEST: build and no-op on Fuchsia
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2022
godofredoc
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2022
* 5d39fbc Roll Fuchsia Mac SDK from KyHYWmWPl... to HONostNiI... (flutter/engine#30906) * 31abc8f [fuchsia] Set blending mode on flatland images (flutter/engine#30890) * 8c838dc Roll Skia from 7022d7456730 to 466df1e697fd (1 revision) (flutter/engine#30907) * 00a45c3 Roll Dart SDK from 4a4f34a69fc1 to 72aa28127bbf (9 revisions) (flutter/engine#30908) * ae34643 Roll Skia from 466df1e697fd to 9f231c330962 (2 revisions) (flutter/engine#30910) * 7a33b4b [fuchsia] Update Vulkan header version to 1.2.198. (flutter/engine#30770)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
* 5d39fbc Roll Fuchsia Mac SDK from KyHYWmWPl... to HONostNiI... (flutter/engine#30906) * 31abc8f [fuchsia] Set blending mode on flatland images (flutter/engine#30890) * 8c838dc Roll Skia from 7022d7456730 to 466df1e697fd (1 revision) (flutter/engine#30907) * 00a45c3 Roll Dart SDK from 4a4f34a69fc1 to 72aa28127bbf (9 revisions) (flutter/engine#30908) * ae34643 Roll Skia from 466df1e697fd to 9f231c330962 (2 revisions) (flutter/engine#30910) * 7a33b4b [fuchsia] Update Vulkan header version to 1.2.198. (flutter/engine#30770)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the downstream Vulkan header for Fuchsia
to 1.2.198 so that it could support the upstream
FUCHSIA buffer collection extension.
TEST: build and no-op on Fuchsia
Bug: flutter/flutter#96312