This repository was archived by the owner on Feb 25, 2025. It is now read-only.
A Color.fromRGBO #3043
Merged
A Color.fromRGBO #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
force-pushed
the
color_from_rgbo
branch
from
79d682e to
6b838d6
Compare
Hixie
reviewed
Sep 20, 2016
| /// transparent and 1.0 being fully opaque. | ||
| /// * `r` is [red], from 0 to 255. | ||
| /// * `g` is [red], from 0 to 255. | ||
| /// * `b` is [red], from 0 to 255. |
There was a problem hiding this comment.
opacity should come last here.
Hixie
reviewed
Sep 20, 2016
| /// transparent and 1.0 being fully opaque. | ||
| /// * `r` is [red], from 0 to 255. | ||
| /// * `g` is [red], from 0 to 255. | ||
| /// * `b` is [red], from 0 to 255. |
There was a problem hiding this comment.
Maybe mention that this is the same numbers as CSS rgba()?
Hixie
reviewed
Sep 20, 2016
| /// transparent and 1.0 being fully opaque. | ||
| /// * `r` is [red], from 0 to 255. | ||
| /// * `g` is [red], from 0 to 255. | ||
| /// * `b` is [red], from 0 to 255. |
There was a problem hiding this comment.
maybe mention here and in fromARGB that out-of-range values are masked off.
|
|
Sometimes it is convenient to construct a color from an opacity rather than an alpha value. Fixes flutter/flutter#5205
abarth
force-pushed
the
color_from_rgbo
branch
from
6b838d6 to
facf930
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is convenient to construct a color from an opacity rather than an
alpha value. Unfortunately, this constructor cannot be const because there's no
const way to convert from a double to the internal representation of a Color,
which is an int.
Fixes flutter/flutter#5205