Skip to content
This repository has been archived by the owner on Feb 25, 2025. It is now read-only.

Declare flutter_gdb as a Python 2 script #28138

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

jason-simmons
Copy link
Member

The script has not been ported to Python 3. The environment required by
Python 3 (e.g. PYTHONHOME) may conflict with the environment expected by
the Python 2 runtime linked into the version of GDB launched by the script.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

Thanks. Not sure why the licence failure (didn't look at the error) -- seems unlikely to be related to this though I'd expect.

@jason-simmons jason-simmons force-pushed the gdb_script_python2 branch 9 times, most recently from d1ff479 to 36b9686 Compare August 18, 2021 02:36
The script has not been ported to Python 3.  The environment required by
Python 3 (e.g. PYTHONHOME) may conflict with the environment expected by
the Python 2 runtime linked into the version of GDB launched by the script.
@jason-simmons jason-simmons merged commit b13c765 into flutter:master Aug 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Aug 18, 2021
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
The script has not been ported to Python 3.  The environment required by
Python 3 (e.g. PYTHONHOME) may conflict with the environment expected by
the Python 2 runtime linked into the version of GDB launched by the script.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants