Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly provide the string encoding #27851

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Conversation

blasten
Copy link

@blasten blasten commented Aug 2, 2021

Fixes flutter/flutter#87514

The scripts are currently uploading b'<engine-hash>' after #27838

@google-cla google-cla bot added the cla: yes label Aug 2, 2021
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

@flar flar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 2, 2021
@flar flar merged commit 9741683 into flutter:master Aug 2, 2021
@flar
Copy link
Contributor

flar commented Aug 2, 2021

Pushing manually to get the rollers running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine rolls are down on failure to resolve files
3 participants