Added the ability to set properties in interface builder for FlutterViewController #19458

gaaclarke · 2020-07-01T20:58:31Z

Description

Added the ability to set properties in interface builder for FlutterViewControllers and their subclasses. I also added one property that controls if the created engine allows headless execution.

Since our templates use Storyboards we should probably support them better.

Related Issues

[research into multiple flutters]

Tests

Covered in other integration tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

fluttergithubbot · 2020-07-01T20:58:33Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jmagman · 2020-07-06T17:53:44Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

@@ -137,7 +141,15 @@ - (instancetype)initWithNibName:(NSString*)nibNameOrNil bundle:(NSBundle*)nibBun
 }

 - (instancetype)initWithCoder:(NSCoder*)aDecoder {
-  return [self initWithProject:nil nibName:nil bundle:nil];
+  self = [super initWithCoder:aDecoder];


The properties should be pulled off aDecoder at initialization (with copies where appropriate)

_viewOpaque = aDecoder->_viewOpaque; _weakFactory = aDecoder->_weakFactory; _engine = aDecoder->_engine; _flutterView = aDecoder->_flutterView; _isDisplayingFlutterUI = [aDecoder decodeObjectForKey:@"isDisplayingFlutterUI"]; _isHomeIndicatorHidden = [aDecoder decodeObjectForKey:@"isHomeIndicatorHidden"]; _isPresentingViewControllerAnimating = [aDecoder decodeObjectForKey:@"isPresentingViewControllerAnimating"];

not re-set up as if it's a newly initialized object (it's being deserialized).

The NSCoder doesn't have a representation of a full object. It just has what is coming from the xib, so it won't have things like a _weakFactory. The default initWithCoder will use key-value to set properties that have been specified in the xib, you don't need to create custom readers for them.

I never did grok UIViewController or NSViewController. Looked at more docs, you're right. Magic APIs...

jmagman · 2020-07-06T17:54:28Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

 - (instancetype)initWithProject:(nullable FlutterDartProject*)project
                        nibName:(nullable NSString*)nibName
                         bundle:(nullable NSBundle*)nibBundle {
  self = [super initWithNibName:nibName bundle:nibBundle];
  if (self) {
-    _viewOpaque = YES;
-    _weakFactory = std::make_unique<fml::WeakPtrFactory<FlutterViewController>>(self);
-    _engine.reset([[FlutterEngine alloc] initWithName:@"io.flutter"


How is this working? Where is _engine set?

_engine is now set in sharedSeutpWithProject

Oh, to be clear, awakeFromNib is calling sharedSetupWithProject. Only after that call are the key-value properties set.

jmagman · 2020-07-06T17:54:44Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

+- (void)sharedSetupWithProject:(nullable FlutterDartProject*)project {
+  _viewOpaque = YES;
+  _weakFactory = std::make_unique<fml::WeakPtrFactory<FlutterViewController>>(self);
+  _engine.reset([[FlutterEngine alloc] initWithName:@"io.flutter"


Isn't _engine nil here?

_engine is a smart pointer, it represents nil until this reset function is called on it.

jmagman

LGTM

…iewController.

gaaclarke · 2020-07-10T00:23:26Z

Landing on red, reran the failing test and it passed here: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/aaclarke_google.com/6aeea40c8ec6a670a06ab6aed701c523a4ac49cf7c9b04ab4a34367490d483ce/+/annotations?server=chromium-swarm.appspot.com

…FlutterViewController. (flutter/engine#19458)

* 160b268 Set locale in Linux shell (flutter/engine#19470) * c479b93 Fix documentation of unset platform view ID (flutter/engine#19320) * f3ab78d Fix clipboard paste functionality not working (flutter/engine#19489) * 9345347 Added the ability to set properties in interface builder for FlutterViewController. (flutter/engine#19458) * 69fdf6d Use identical in hashValues instead of operator== (flutter/engine#19615) * 3dc8163 [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak (flutter/engine#19620) * b16c47d using text capitalization value in web (flutter/engine#19564) * 49c0161 Roll Skia from 16bf7d31c819 to 4d48bb35972f (32 revisions) (flutter/engine#19635) * 2d6afa7 Roll Skia from 4d48bb35972f to 9f821489c9f3 (4 revisions) (flutter/engine#19638) * 35f59b9 Roll Fuchsia Linux SDK from NC9pp... to 5R9a0... (flutter/engine#19639) * 53038e2 Roll Fuchsia Mac SDK from iwQCA... to Wym-S... (flutter/engine#19640) * d9e68f4 Roll Skia from 9f821489c9f3 to f8a6b5b4b0d0 (1 revision) (flutter/engine#19643) * d329617 Changes to fix build errors in google3. (flutter/engine#19616) * dd0a6c4 Roll Skia from f8a6b5b4b0d0 to 5160e8caa226 (9 revisions) (flutter/engine#19647) * d98d539 Manual Roll of Dart dfdc7e45c5...06cb010247 (flutter/engine#19649) * dfd0727 don't throw error for the new autofill request (flutter/engine#19633) * 39e98d2 Manual Skia roll to c91db040ad18b9cc3236e342e9acca020eaafd10 (flutter/engine#19650) * f9acd08 Avoid a copy in EncodeImage (flutter/engine#19504) * 7e101f1 Roll Fuchsia Linux SDK from 5R9a0... to GOf1K... (flutter/engine#19656) * f3be9f1 Incorporate compat info changes into flutter engine (flutter/engine#19606) * 9188ff6 Manual Roll of Dart 707c6404f9...dfdc7e45c5 (flutter/engine#19657) * cbdd3e2 Roll Fuchsia Mac SDK from Wym-S... to -v4bL... (flutter/engine#19661) * 6efb152 Roll Dart SDK from 707c6404f969 to 0e25306d3f78 (4 revisions) (flutter/engine#19666) * 22a440c Roll Dart SDK from 0e25306d3f78 to 6d06476bae6b (1 revision) (flutter/engine#19669) * 8063923 Roll Fuchsia Linux SDK from GOf1K... to QWI76... (flutter/engine#19671) * c99deb0 CkPaint uses SkPaint (flutter/engine#19562) * 015f2ea Use the main bundle if the App bundle is not found (flutter/engine#18749) * f82d30b Roll Dart SDK from 6d06476bae6b to a9e67d81941a (3 revisions) (flutter/engine#19677) * 61b2fd2 Roll Fuchsia Mac SDK from -v4bL... to phQJt... (flutter/engine#19681) * 74b541d Roll Fuchsia Linux SDK from QWI76... to mrlGt... (flutter/engine#19682) * 25ce3db Roll Skia from c91db040ad18 to e4f36d7ac8f5 (20 revisions) (flutter/engine#19686) * 162dba1 Roll Skia from e4f36d7ac8f5 to ed15b1c39b8b (1 revision) (flutter/engine#19687) * f97c38b Roll Fuchsia Mac SDK from phQJt... to kEVc6... (flutter/engine#19688) * 40c4ee8 Roll Fuchsia Linux SDK from mrlGt... to YfVT0... (flutter/engine#19690) * ec944b0 Roll Skia from ed15b1c39b8b to 1434ce1aa94d (1 revision) (flutter/engine#19692) * 7ce988a Roll Skia from 1434ce1aa94d to f64be13cbf84 (2 revisions) (flutter/engine#19695) * 5f7ca41 Roll Fuchsia Mac SDK from kEVc6... to hRul_... (flutter/engine#19696) * d24549c Roll Skia from f64be13cbf84 to 041796e60364 (3 revisions) (flutter/engine#19697) * 617bd88 Roll Dart SDK from a9e67d81941a to fecc8163afc7 (3 revisions) (flutter/engine#19703) * 8d241e4 [Android] Prevent FlutterRenderer listener from calling JNI after detach (flutter/engine#19558) * 309e514 Roll Skia from 041796e60364 to d1ce4cb2beb8 (2 revisions) (flutter/engine#19704) * 211f18e Roll Skia from d1ce4cb2beb8 to 7c1967700b44 (6 revisions) (flutter/engine#19707) * 0532227 Roll Skia from 7c1967700b44 to 439709a97dfd (8 revisions) (flutter/engine#19712) * 1e02bfd Support decimal information on the TextInputType (flutter/engine#19664) * 7a95e32 Linux: Use a hash table to map cursors (flutter/engine#19561) * df23044 [web] Implement ulps for path ops (flutter/engine#19711) * 4a3aa4d Fixes typo in android_context_gl.h (flutter/engine#19700) * 5b966eb Roll Skia from 439709a97dfd to 2604a89d3353 (3 revisions) (flutter/engine#19715) * d024ae4 [fuchsia] Use memory_requirements_2 extension. (flutter/engine#19678) * 4392fbf Roll Fuchsia Linux SDK from YfVT0... to 2ct5j... (flutter/engine#19720) * ab05c79 Roll Fuchsia Mac SDK from hRul_... to ZXLvD... (flutter/engine#19721) * c05ca7e Roll Dart SDK from fecc8163afc7 to f997d62a6d29 (13 revisions) (flutter/engine#19722) * ae37971 Remove xcpretty from unit tests to see full output on test failures (flutter/engine#19667) * 91f80ef Moved to RMSE for image comparison to account for slight variations in golden image tests (flutter/engine#19658) * 1e23309 Wait for platform view to appear in iOS UI tests (flutter/engine#19725)

fluttergithubbot added the platform-ios label Jul 1, 2020

googlebot added the cla: yes label Jul 1, 2020

gaaclarke force-pushed the flutter-view-controller-xib branch from bbb3cca to 94f5c28 Compare July 1, 2020 21:00

gaaclarke marked this pull request as draft July 1, 2020 21:01

gaaclarke force-pushed the flutter-view-controller-xib branch from 94f5c28 to 941c060 Compare July 1, 2020 21:04

gaaclarke marked this pull request as ready for review July 1, 2020 21:16

gaaclarke requested a review from jmagman July 1, 2020 21:16

jmagman requested changes Jul 6, 2020

View reviewed changes

gaaclarke requested a review from jmagman July 8, 2020 21:39

jmagman approved these changes Jul 8, 2020

View reviewed changes

gaaclarke force-pushed the flutter-view-controller-xib branch from 941c060 to 47fa4a4 Compare July 8, 2020 23:06

Added the ability to set properties in interface builder for FlutterV…

3d0d6dd

…iewController.

gaaclarke force-pushed the flutter-view-controller-xib branch from 47fa4a4 to 3d0d6dd Compare July 9, 2020 21:41

gaaclarke merged commit 9345347 into flutter:master Jul 10, 2020

engine-flutter-autoroll mentioned this pull request Jul 13, 2020

Roll Engine from f10f17257300 to 0532227fc116 (43 revisions) flutter/flutter#61387

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2020

9345347 Added the ability to set properties in interface builder for …

4c4ef5e

…FlutterViewController. (flutter/engine#19458)

engine-flutter-autoroll mentioned this pull request Jul 13, 2020

Roll Engine from f10f17257300 to 7a95e32fc505 (45 revisions) flutter/flutter#61393

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2020

9345347 Added the ability to set properties in interface builder for …

8f0478c

…FlutterViewController. (flutter/engine#19458)

engine-flutter-autoroll mentioned this pull request Jul 13, 2020

Roll Engine from f10f17257300 to d024ae400949 (49 revisions) flutter/flutter#61396

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2020

9345347 Added the ability to set properties in interface builder for …

9883edd

…FlutterViewController. (flutter/engine#19458)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020

9345347 Added the ability to set properties in interface builder for …

5c684ef

…FlutterViewController. (flutter/engine#19458)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020

9345347 Added the ability to set properties in interface builder for …

57e45ec

…FlutterViewController. (flutter/engine#19458)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020

9345347 Added the ability to set properties in interface builder for …

773c435

…FlutterViewController. (flutter/engine#19458)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the ability to set properties in interface builder for FlutterViewController #19458

Added the ability to set properties in interface builder for FlutterViewController #19458

gaaclarke commented Jul 1, 2020

fluttergithubbot commented Jul 1, 2020

jmagman Jul 6, 2020

gaaclarke Jul 8, 2020

jmagman Jul 8, 2020 •

edited

Loading

jmagman Jul 6, 2020

gaaclarke Jul 8, 2020

gaaclarke Jul 8, 2020

jmagman Jul 6, 2020

gaaclarke Jul 8, 2020

jmagman left a comment

gaaclarke commented Jul 10, 2020

Added the ability to set properties in interface builder for FlutterViewController #19458

Added the ability to set properties in interface builder for FlutterViewController #19458

Conversation

gaaclarke commented Jul 1, 2020

Description

Related Issues

Tests

Checklist

Breaking Change

fluttergithubbot commented Jul 1, 2020

jmagman Jul 6, 2020

Choose a reason for hiding this comment

gaaclarke Jul 8, 2020

Choose a reason for hiding this comment

jmagman Jul 8, 2020 • edited Loading

Choose a reason for hiding this comment

jmagman Jul 6, 2020

Choose a reason for hiding this comment

gaaclarke Jul 8, 2020

Choose a reason for hiding this comment

gaaclarke Jul 8, 2020

Choose a reason for hiding this comment

jmagman Jul 6, 2020

Choose a reason for hiding this comment

gaaclarke Jul 8, 2020

Choose a reason for hiding this comment

jmagman left a comment

Choose a reason for hiding this comment

gaaclarke commented Jul 10, 2020

jmagman Jul 8, 2020 •

edited

Loading