Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hot reload and hot restart buttons to the simulated devtools environment #6275

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

kenzieschmoll
Copy link
Member

This will allow extension developers to easily hot reload or hot restart the connected app:
Screenshot 2023-08-28 at 4 10 30 PM

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner August 28, 2023 23:12
@kenzieschmoll kenzieschmoll requested review from CoderDake and removed request for a team August 28, 2023 23:12
@@ -1,3 +1,6 @@
## 0.0.3-wip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not dev? What is the difference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe wip indicates a package that is not yet published, but I don't think it is enforced.
@jonasfj are there official pub guidelines around how you should version an unpublished package?

Copy link
Member

@jonasfj jonasfj Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from pub, there are no guidelines.

For external package maintenance the Dart team generally follows:
https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#publishing-a-package

I didn't write it, and I'll admit I sometimes fail to follow it, but I like the idea of using a -wip to denote the fact that the version haven't been published yet.


From a pub-perspective, if a package isn't intended to be published, then please add:

publish_to: none  # Do not publish this package, because: ...

If you know that you intend to publish this package soon, but isn't ready yet, please consider publishing a dummy package as version 0.0.1, don't care if it's empty and ugly -- just reserve the package name. It's a mess if someone sees the package you're developing, can't wait to try it and decides to publish it for you -- this happens when people are experimenting 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants